From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2 1/3] avutil/dict: add av_dict_pop
Date: Fri, 20 Oct 2023 10:18:17 +0200
Message-ID: <169778989751.30698.15022276759252509666@lain.khirnov.net> (raw)
In-Reply-To: <GV1P250MB073710C040389D3EECB372378F29A@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>
Quoting Andreas Rheinhardt (2023-07-03 20:02:25)
> Marvin Scholz:
> > I honestly can't think of a sensible API design for this,
> > if you have any idea feel free to share.
> >
>
> The only way I can think of that allows this is for the user to pass a
> pointer to a (const) AVDictionaryEntry, namely the entry that the user
> wishes to pop. This is of course cumbersome, because it would be two
> function calls.
We could start guaranteeing that entries with the same key are always
returned in insertion order. Now that I think of it there's some code in
ffmpeg CLI that relies on that.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-10-20 8:18 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-01 11:44 [FFmpeg-devel] [PATCH " Marvin Scholz
2023-05-01 11:44 ` [FFmpeg-devel] [PATCH 2/3] avformat/tee: use av_dict_pop Marvin Scholz
2023-06-25 12:07 ` "zhilizhao(赵志立)"
2023-05-01 11:44 ` [FFmpeg-devel] [PATCH 3/3] avutil/dict: constify av_dict_get return Marvin Scholz
2023-06-05 10:05 ` Anton Khirnov
2023-05-21 23:52 ` [FFmpeg-devel] [PATCH 1/3] avutil/dict: add av_dict_pop Stefano Sabatini
2023-05-22 9:23 ` Marvin Scholz
2023-05-26 6:05 ` Stefano Sabatini
2023-05-26 9:11 ` Marvin Scholz
2023-05-26 20:02 ` Michael Niedermayer
2023-05-26 20:51 ` Marvin Scholz
2023-05-26 20:06 ` James Almer
2023-06-04 14:25 ` Stefano Sabatini
2023-06-04 14:34 ` Marvin Scholz
2023-06-05 8:08 ` Stefano Sabatini
2023-06-05 10:09 ` Anton Khirnov
2023-06-05 10:04 ` Anton Khirnov
2023-06-25 10:49 ` [FFmpeg-devel] [PATCH v2 " Marvin Scholz
2023-06-25 10:49 ` [FFmpeg-devel] [PATCH v2 2/3] avformat/tee: use av_dict_pop Marvin Scholz
2023-07-02 8:47 ` Stefano Sabatini
2023-06-25 10:49 ` [FFmpeg-devel] [PATCH v2 3/3] avutil/dict: constify av_dict_get return Marvin Scholz
2023-07-02 9:06 ` Stefano Sabatini
2023-07-02 8:43 ` [FFmpeg-devel] [PATCH v2 1/3] avutil/dict: add av_dict_pop Stefano Sabatini
2023-07-02 11:49 ` Marvin Scholz
2023-07-03 0:18 ` Andreas Rheinhardt
2023-07-03 9:11 ` Marvin Scholz
2023-07-03 18:02 ` Andreas Rheinhardt
2023-07-03 22:41 ` Marvin Scholz
2023-10-20 8:18 ` Anton Khirnov [this message]
2023-10-20 14:00 ` Andreas Rheinhardt
2023-10-20 14:33 ` Anton Khirnov
2023-10-20 15:42 ` Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169778989751.30698.15022276759252509666@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git