Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/mov: The iloc test is not redundant
Date: Thu, 19 Oct 2023 19:42:30 +0200
Message-ID: <169773735094.30698.2006289459200607623@lain.khirnov.net> (raw)
In-Reply-To: <20231019163313.GH3543730@pb2>

Quoting Michael Niedermayer (2023-10-19 18:33:13)
> On Thu, Oct 19, 2023 at 01:10:18PM +0200, Anton Khirnov wrote:
> > Quoting Michael Niedermayer (2023-10-15 02:13:23)
> > > Fixes: Assertion failure
> > > Fixes: 62866/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-5282997370486784
> > > 
> > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> > > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > > ---
> > 
> > The commit message is useless.
> 
> This comment is also not that usefull
> What would you like to see in the commit message ?
> 
> The 2 checks are not redundant. Should the message detail how
> the assertion failure occured ?

At least two people previously thought that the condition is redundant,
so it seems clear to me that an explanation is in order.

I actually find it quite baffling that this is not obvious to you. Do
you really think that "Fixes: Assertion failure" is sufficient
explanation for anyone reading this patch?

> Would you prefer if the 2nd condition produces an error instead of return 0 ?

Maybe. Depending on the conditions under which this happens.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2023-10-19 17:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-15  0:13 Michael Niedermayer
2023-10-19 11:10 ` Anton Khirnov
2023-10-19 16:33   ` Michael Niedermayer
2023-10-19 17:42     ` Anton Khirnov [this message]
2023-10-19 18:53       ` Michael Niedermayer
2023-10-20  8:34         ` Anton Khirnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=169773735094.30698.2006289459200607623@lain.khirnov.net \
    --to=anton@khirnov.net \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git