From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/2] aacdec: padding skip improvements
Date: Thu, 19 Oct 2023 10:40:46 +0200
Message-ID: <169770484624.32606.5385124111650249075@lain.khirnov.net> (raw)
In-Reply-To: <Nh4nBk8--3-9@lynne.ee>
Quoting Lynne (2023-10-19 04:38:51)
> @@ -3471,6 +3478,9 @@ static const AVOption options[] = {
> { "coded", "order in which the channels are coded in the bitstream",
> 0, AV_OPT_TYPE_CONST, { .i64 = CHANNEL_ORDER_CODED }, .flags = AACDEC_FLAGS, "channel_order" },
>
> + { "padding", "Override the padding at the start of a stream.\n",
> + offsetof(AACContext, override_padding), AV_OPT_TYPE_INT, { .i64 = 1024 }, 1024, 8192, AACDEC_FLAGS },
Why should this be a decoder option when the caller can already control
it by inserting AV_PKT_DATA_SKIP_SAMPLES?
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-10-19 8:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 2:37 [FFmpeg-devel] [PATCH 1/2] lavc/internal: add skip_samples2 field Lynne
[not found] ` <Nh4mqjI--3-9@lynne.ee-Nh4muoe----9>
2023-10-19 2:38 ` [FFmpeg-devel] [PATCH 2/2] aacdec: padding skip improvements Lynne
2023-10-19 8:40 ` Anton Khirnov [this message]
2023-10-19 12:48 ` Lynne
2023-10-19 15:48 ` Anton Khirnov
[not found] ` <Nh4nBk8--3-9@lynne.ee-Nh4nEdF----9>
2023-10-19 2:39 ` Lynne
2023-10-19 8:39 ` [FFmpeg-devel] [PATCH 1/2] lavc/internal: add skip_samples2 field Anton Khirnov
2023-10-19 12:49 ` Lynne
2023-10-19 15:50 ` Anton Khirnov
2023-10-19 12:50 ` James Almer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169770484624.32606.5385124111650249075@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git