From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 047844754E for ; Thu, 12 Oct 2023 13:57:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3183068C9B8; Thu, 12 Oct 2023 16:57:00 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2266C68BA18 for ; Thu, 12 Oct 2023 16:56:53 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id D9692240498 for ; Thu, 12 Oct 2023 15:56:52 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id nOKYUtyB2bqv for ; Thu, 12 Oct 2023 15:56:52 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 3B66B2400FF for ; Thu, 12 Oct 2023 15:56:52 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 13BA91601B9; Thu, 12 Oct 2023 15:56:52 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <169711473601.32606.17581920132320741382@lain.khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Thu, 12 Oct 2023 15:56:52 +0200 Message-ID: <169711901206.32606.6907561265760440957@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 21/42] avcodec/refstruct: Allow to always return zeroed pool entries X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Andreas Rheinhardt (2023-10-12 15:25:14) > Anton Khirnov: > > Quoting Andreas Rheinhardt (2023-09-19 21:57:13) > >> diff --git a/libavcodec/refstruct.h b/libavcodec/refstruct.h > >> Furthermore, it also makes the pool behave as if the > >> FF_REFSTRUCT_POOL_FLAG_NO_ZEROING flag had been provided. > > > > What does this imply for the caller? > > > > It means that if you have an init callback, that the object has not been > zeroed before it is given to you. So the init function would probably be > only useful for logging. If you don't have an init callback at all, you > won't notice the difference. > The rationale for this behaviour is that it makes no sense to zero > initially if it is zeroed generically before every use and I want to > spare the user to set the FF_REFSTRUCT_POOL_FLAG_NO_ZEROING flag (which > could be easily forgotten). Can you mention this in the docs then? -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".