From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C65434747B for ; Tue, 10 Oct 2023 11:48:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2BA3C68CA6D; Tue, 10 Oct 2023 14:48:26 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B62BB68C87E for ; Tue, 10 Oct 2023 14:48:18 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 7D9BF24048D; Tue, 10 Oct 2023 13:48:18 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id iJCO1RL54ztZ; Tue, 10 Oct 2023 13:48:18 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 0F99F2400FF; Tue, 10 Oct 2023 13:48:18 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id E16311601B9; Tue, 10 Oct 2023 13:48:17 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: Mail-Followup-To: FFmpeg development discussions and patches , Andreas Rheinhardt Date: Tue, 10 Oct 2023 13:48:17 +0200 Message-ID: <169693849790.6638.7464176663071854869@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 5/7] fftools/ffmpeg_demux: Don't use fake object with av_opt_eval X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Andreas Rheinhardt (2023-10-07 02:40:29) > The av_opt_eval family of functions emits errors messages on error > and can therefore not be used with fake objects when the AVClass > has a custom item_name callback. The AVClass for AVCodecContext > has such a custom callback (it searches whether an AVCodec is set > to use its name). In practice it means that whatever is directly > after the "cc" pointer to the AVClass for AVCodec in the stack frame > of ist_add() will be treated as a pointer to an AVCodec with > unpredictable consequences. > > Fix this by using an actual AVCodecContext instead of a fake object. > > Signed-off-by: Andreas Rheinhardt > --- > fftools/ffmpeg_demux.c | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) Ok -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".