From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BA96347178 for ; Tue, 10 Oct 2023 11:13:09 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 07F6C68CAC2; Tue, 10 Oct 2023 14:13:07 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2D0EF68C92B for ; Tue, 10 Oct 2023 14:13:01 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id E8B0524048D for ; Tue, 10 Oct 2023 13:13:00 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id QGbW_kdO8syu for ; Tue, 10 Oct 2023 13:13:00 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 7807A2400FF for ; Tue, 10 Oct 2023 13:13:00 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 65FC91601B9; Tue, 10 Oct 2023 13:13:00 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20231007162503.1057-7-jamrial@gmail.com> References: <20231007162503.1057-1-jamrial@gmail.com> <20231007162503.1057-7-jamrial@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Tue, 10 Oct 2023 13:13:00 +0200 Message-ID: <169693638039.6638.1992030463748664172@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 6/7] fftools/ffmpeg: support applying container level cropping X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2023-10-07 18:25:02) > Signed-off-by: James Almer > --- > fftools/ffmpeg.h | 3 +++ > fftools/ffmpeg_demux.c | 6 ++++++ > fftools/ffmpeg_enc.c | 24 +++++++++++++----------- > fftools/ffmpeg_filter.c | 23 +++++++++++++++++++++++ > fftools/ffmpeg_opt.c | 3 +++ > 5 files changed, 48 insertions(+), 11 deletions(-) > > diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h > index b059ecbb9f..94ada9d586 100644 > --- a/fftools/ffmpeg.h > +++ b/fftools/ffmpeg.h > @@ -155,6 +155,8 @@ typedef struct OptionsContext { > int nb_hwaccel_output_formats; > SpecifierOpt *autorotate; > int nb_autorotate; > + SpecifierOpt *apply_cropping; > + int nb_apply_cropping; I would prefer to handle this similarly to the "display_rotation" option - give the user the option to override container-stored values (which includes setting them to zero, to ignore them). -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".