Re: [FFmpeg-devel] [PATCH 6/7] fftools/ffmpeg: support applying container level cropping

From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 6/7] fftools/ffmpeg: support applying container level cropping
Date: Tue, 10 Oct 2023 13:13:00 +0200
Message-ID: <169693638039.6638.1992030463748664172@lain.khirnov.net> (raw)
In-Reply-To: <20231007162503.1057-7-jamrial@gmail.com>

Quoting James Almer (2023-10-07 18:25:02)
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  fftools/ffmpeg.h        |  3 +++
>  fftools/ffmpeg_demux.c  |  6 ++++++
>  fftools/ffmpeg_enc.c    | 24 +++++++++++++-----------
>  fftools/ffmpeg_filter.c | 23 +++++++++++++++++++++++
>  fftools/ffmpeg_opt.c    |  3 +++
>  5 files changed, 48 insertions(+), 11 deletions(-)
> 
> diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h
> index b059ecbb9f..94ada9d586 100644
> --- a/fftools/ffmpeg.h
> +++ b/fftools/ffmpeg.h
> @@ -155,6 +155,8 @@ typedef struct OptionsContext {
>      int        nb_hwaccel_output_formats;
>      SpecifierOpt *autorotate;
>      int        nb_autorotate;
> +    SpecifierOpt *apply_cropping;
> +    int        nb_apply_cropping;

I would prefer to handle this similarly to the "display_rotation"
option - give the user the option to override container-stored values
(which includes setting them to zero, to ignore them).

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".