Re: [FFmpeg-devel] [PATCH 4/7] avformat/avformat: add a flag to signal muxers that support storing cropping values

From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 4/7] avformat/avformat: add a flag to signal muxers that support storing cropping values
Date: Tue, 10 Oct 2023 13:09:52 +0200
Message-ID: <169693619274.6638.10416615280449969394@lain.khirnov.net> (raw)
In-Reply-To: <20231007162503.1057-5-jamrial@gmail.com>

Quoting James Almer (2023-10-07 18:25:00)
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  libavformat/avformat.h | 1 +
>  libavformat/mux.c      | 8 ++++++++
>  2 files changed, 9 insertions(+)
> 
> diff --git a/libavformat/avformat.h b/libavformat/avformat.h
> index 9e7eca007e..c099ca8a01 100644
> --- a/libavformat/avformat.h
> +++ b/libavformat/avformat.h
> @@ -500,6 +500,7 @@ typedef struct AVProbeData {
>                                          The user or muxer can override this through
>                                          AVFormatContext.avoid_negative_ts
>                                          */
> +#define AVFMT_CROPPING     0x80000 /**< Format supports storing cropping values */

I have mixed feeelings about this patch, for a bunch of reasons:
* It is quite ad-hoc - we don't do this for other side data types, and
  this approach would not scale if we did.
* If we do want to signal this, we probably want to distinguish between
  support for global and per-packet values.
* How do you expect this to be useful to the callers? I don't see this
  flag actually being used in the ffmpeg CLI patch.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".