From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D9C97472AA for ; Wed, 4 Oct 2023 14:46:48 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AC04B68CBD1; Wed, 4 Oct 2023 17:46:46 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5E84C68CA86 for ; Wed, 4 Oct 2023 17:46:40 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 24CC9240490 for ; Wed, 4 Oct 2023 16:46:40 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id JMA6lOb3Ff0y for ; Wed, 4 Oct 2023 16:46:39 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 9F4AB240445 for ; Wed, 4 Oct 2023 16:46:39 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 7E51B1601B9; Wed, 4 Oct 2023 16:46:39 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20231004122849.56604-5-jamrial@gmail.com> References: <20231004122849.56604-1-jamrial@gmail.com> <20231004122849.56604-5-jamrial@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Wed, 04 Oct 2023 16:46:39 +0200 Message-ID: <169643079949.6638.10107251396186814606@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 04/11] avcodec/packet: add some documentation for AVPacketSideData X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2023-10-04 14:28:42) > Explaining what or who may use it, and in what scenarios. > > Signed-off-by: James Almer > --- > libavcodec/packet.h | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/libavcodec/packet.h b/libavcodec/packet.h > index 96fc0084d6..85b3eeb728 100644 > --- a/libavcodec/packet.h > +++ b/libavcodec/packet.h > @@ -312,6 +312,25 @@ enum AVPacketSideDataType { > > #define AV_PKT_DATA_QUALITY_FACTOR AV_PKT_DATA_QUALITY_STATS //DEPRECATED > > +/** > + * This structure stores information for decoding, presenting, or otherwise ^ I didn't mean for you to drop the 'auxiliary' that used to be here - it (or some other equivalent wording) should be here to make it clear that side data applies in additon/on top of the main coded bitstream. > + * processing the coded stream. It is typically exported by demuxers and > + * encoders and can be fed to decoders and muxers in a per packet basis, or as ^ / \ either > + * global side data (applying to the entire coded stream) as follows: The following bullet points apply only to the global side data, so you should start a new sentence that makes that explicit. > + * - During demuxing, it will be exported through global side data in > + * @ref AVStream.codecpar.side_data "AVStream's codec parameters", which can > + * then be passed as input to decoders through the > + * @ref AVCodecContext.coded_side_data "decoder context's side data", for > + * initialization. > + * - For muxing, it can be fed through global side data in > + * @ref AVStream.codecpar.side_data "AVStream's codec parameters", typically > + * the output of encoders through the @ref AVCodecContext.coded_side_data > + * "encoder context's side data", for initialization. > + * > + * Different modules may accept or export different types of side data > + * depending on media type and codec. Refer to @ref AVPacketSideDataType for a > + * list of defined types and where they may be found or used. > + */ -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".