From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AB052472A4 for ; Wed, 4 Oct 2023 14:36:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A87C968CBD0; Wed, 4 Oct 2023 17:36:56 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A18B468CAF3 for ; Wed, 4 Oct 2023 17:36:49 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 5E4A0240490 for ; Wed, 4 Oct 2023 16:36:49 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id eZZJ3ZUwflEa for ; Wed, 4 Oct 2023 16:36:48 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id BA35E240445 for ; Wed, 4 Oct 2023 16:36:48 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 953841601B9; Wed, 4 Oct 2023 16:36:48 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20230927131242.1950-1-jamrial@gmail.com> <20230927131242.1950-10-jamrial@gmail.com> <169633649730.6638.7006599604326857996@lain.khirnov.net> <8144112d-046f-46a8-9ee2-dbc26cdb6edf@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Wed, 04 Oct 2023 16:36:48 +0200 Message-ID: <169643020858.6638.4949845195175076909@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 09/11] avcodec/decode: check for global side data in AVCodecContext side data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2023-10-04 05:22:38) > > Actually, both tests use ffprobe, which never injected stream side data > into packets before this set, so the ffmpeg code removed in 10/11 makes > no difference. > > Adding DISPLAYMATRIX to the global map here will still mean ffmpeg.c > will pass stream side data to decoded frames, though, even if no test > covers it. So it would be nice to know why was it being skipped. Honestly I doubt there's a good reason, the handling of displaymatrix in ffmpeg CLI is a convoluted mess. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".