From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B8AEE47BFE for ; Wed, 4 Oct 2023 08:10:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CAC1568CBC3; Wed, 4 Oct 2023 11:10:48 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1C0CD68CACC for ; Wed, 4 Oct 2023 11:10:42 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id B124E240490 for ; Wed, 4 Oct 2023 10:10:41 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id DupEjuDVR1pH for ; Wed, 4 Oct 2023 10:10:41 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 495D1240445 for ; Wed, 4 Oct 2023 10:10:41 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 243D11601B9; Wed, 4 Oct 2023 10:10:40 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <169624366647.6638.939649870927700518@lain.khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Wed, 04 Oct 2023 10:10:40 +0200 Message-ID: <169640704012.6638.8059679259375676782@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 14/42] avcodec/hevcdec: Use RefStruct API for RefPicListTap buffer X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Andreas Rheinhardt (2023-10-02 13:07:14) > Anton Khirnov: > > Quoting Andreas Rheinhardt (2023-09-19 21:57:06) > >> avcodec/hevcdec: Use RefStruct API for RefPicListTap buffer > > ^ > > b > > > >> Given that the RefStruct API relies on the user to know > >> the size of the objects and does not provide a way to get it, > > > > Is there a reason you decided not to provide it, or there just wasn't > > any code that would be improved by it? > > > > In this example, there would be no improvement if RefStruct recorded the > size (in bytes) and provided a getter for it. > > In general, the philosophy of the RefStruct API is that the user and not > the API knows what is in the user data. So the user has to keep track of > stuff like this in cases where the user doesn't know it. > > The only scenario where keeping track of the size would be advantageous > would be for using arrays-of-whatever if the callbacks provided the size > as a parameter (to be ignored by most users), because one could then > derive the number of elements from it. I pondered this, but given that > the AVBuffer API doesn't do so either, I didn't do it. Shall I change this? I'm leaning towards no, it's overly specific and the advantage probably small. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".