From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 38FB947B71 for ; Tue, 3 Oct 2023 12:54:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C9C8268CBF6; Tue, 3 Oct 2023 15:54:54 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E548D68CA19 for ; Tue, 3 Oct 2023 15:54:48 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id AC5ED240490 for ; Tue, 3 Oct 2023 14:54:48 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id iumlHhlgm15s for ; Tue, 3 Oct 2023 14:54:48 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 47884240445 for ; Tue, 3 Oct 2023 14:54:48 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 3478A1601B9; Tue, 3 Oct 2023 14:54:48 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20230927131242.1950-2-jamrial@gmail.com> References: <20230927131242.1950-1-jamrial@gmail.com> <20230927131242.1950-2-jamrial@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Tue, 03 Oct 2023 14:54:48 +0200 Message-ID: <169633768818.6638.11020229402140633510@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 01/11] avcodec/packet: add generic side data helpers X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2023-09-27 15:12:32) > +static AVPacketSideData *packet_side_data_add(AVPacketSideData **psd, int *pnb_sd, > + enum AVPacketSideDataType type, > + void *data, size_t size) > +{ > + AVPacketSideData *sd = *psd, *tmp; > + int nb_sd = *pnb_sd; > + > + for (int i = 0; i < nb_sd; i++) { > + if (sd[i].type != type) > + continue; > + > + av_free(sd[i].data); > + sd[i].data = data; > + sd[i].size = size; > + return &sd[i]; > + } > + > + if (nb_sd + 1U > INT_MAX) seems simpler to write it as nb_sd == INT_MAX > +AVPacketSideData *av_packet_side_data_new(AVPacketSideData **psd, int *pnb_sd, > + enum AVPacketSideDataType type, > + size_t size, int flags) > +{ > + AVPacketSideData *sd = NULL; > + void *data; > + > + if (size > SIZE_MAX - AV_INPUT_BUFFER_PADDING_SIZE) > + return NULL; > + > + data = av_malloc(size + AV_INPUT_BUFFER_PADDING_SIZE); > + if (!data) > + return NULL; IIRC padding needs to be memset to zero -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".