From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1AA7446B27 for ; Tue, 3 Oct 2023 10:18:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9D3F568CB0A; Tue, 3 Oct 2023 13:18:38 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7C6D468CA73 for ; Tue, 3 Oct 2023 13:18:31 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 406A6240490 for ; Tue, 3 Oct 2023 12:18:31 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id yGdnQgjEFJJ3 for ; Tue, 3 Oct 2023 12:18:30 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id B2127240445 for ; Tue, 3 Oct 2023 12:18:30 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 8E3171601B9; Tue, 3 Oct 2023 12:18:30 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20230927131242.1950-9-jamrial@gmail.com> References: <20230927131242.1950-1-jamrial@gmail.com> <20230927131242.1950-9-jamrial@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Tue, 03 Oct 2023 12:18:30 +0200 Message-ID: <169632831055.6638.12430831308758419966@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 08/11] avcodec/hevcdec: check for DOVI configuration record in AVCodecContext side data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2023-09-27 15:12:39) > Signed-off-by: James Almer > --- > libavcodec/avcodec.h | 2 +- > libavcodec/decode.c | 10 ++++++++++ > libavcodec/decode.h | 3 +++ > libavcodec/hevcdec.c | 15 ++++++++++++++- > 4 files changed, 28 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > index da3c5234a0..48a4b73fd3 100644 > --- a/libavcodec/avcodec.h > +++ b/libavcodec/avcodec.h > @@ -1903,7 +1903,7 @@ typedef struct AVCodecContext { > /** > * Additional data associated with the entire coded stream. > * > - * - decoding: unused > + * - decoding: set by user before calling avcodec_open2(). Should be "may be set...", because it's optional. Also, I think this deserves to be mentione in APIchanges. > @@ -3644,12 +3651,18 @@ static av_cold int hevc_decode_init(AVCodecContext *avctx) > atomic_init(&s->wpp_err, 0); > > if (!avctx->internal->is_copy) { > + const AVPacketSideData *sd; > + > if (avctx->extradata_size > 0 && avctx->extradata) { > ret = hevc_decode_extradata(s, avctx->extradata, avctx->extradata_size, 1); > if (ret < 0) { > return ret; > } > } > + > + sd = ff_get_coded_side_data(avctx, AV_PKT_DATA_DOVI_CONF); > + if (sd && sd->size > 0) > + ff_dovi_update_cfg(&s->dovi_ctx, (AVDOVIDecoderConfigurationRecord *) sd->data); Do you have a sample for this? Would be very nice to have a test for this functionality. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".