From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8346C47B0D for ; Mon, 2 Oct 2023 10:47:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BC38C68CD2F; Mon, 2 Oct 2023 13:47:53 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6972A68C815 for ; Mon, 2 Oct 2023 13:47:47 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 2BE3C240490; Mon, 2 Oct 2023 12:47:47 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id L9NrE1XFqtwS; Mon, 2 Oct 2023 12:47:46 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 9DE35240445; Mon, 2 Oct 2023 12:47:46 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 7B0771601B9; Mon, 2 Oct 2023 12:47:46 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: Mail-Followup-To: FFmpeg development discussions and patches , Andreas Rheinhardt Date: Mon, 02 Oct 2023 12:47:46 +0200 Message-ID: <169624366647.6638.939649870927700518@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 14/42] avcodec/hevcdec: Use RefStruct API for RefPicListTap buffer X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Andreas Rheinhardt (2023-09-19 21:57:06) >avcodec/hevcdec: Use RefStruct API for RefPicListTap buffer ^ b > Given that the RefStruct API relies on the user to know > the size of the objects and does not provide a way to get it, Is there a reason you decided not to provide it, or there just wasn't any code that would be improved by it? > we need to store the number of elements allocated ourselves; > but this is actually better than deriving it from the size > in bytes. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/hevc_refs.c | 14 ++++++++------ > libavcodec/hevcdec.c | 5 ++--- > libavcodec/hevcdec.h | 3 ++- > 3 files changed, 12 insertions(+), 10 deletions(-) The actual code looks good. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".