From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8C0AF47B03 for ; Mon, 2 Oct 2023 10:14:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9BD9E68CCF5; Mon, 2 Oct 2023 13:14:44 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A6E0C68CCC5 for ; Mon, 2 Oct 2023 13:14:38 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 4D5DE240490 for ; Mon, 2 Oct 2023 12:14:38 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id aLct51ZliPxW for ; Mon, 2 Oct 2023 12:14:37 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 912D1240445 for ; Mon, 2 Oct 2023 12:14:37 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 6E2D41601B9; Mon, 2 Oct 2023 12:14:37 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <169623987047.6638.13940830507445718036@lain.khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Mon, 02 Oct 2023 12:14:37 +0200 Message-ID: <169624167742.6638.12200023724517637312@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 06/42] avcodec/vp8: Use RefStruct API for seg_map X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Andreas Rheinhardt (2023-10-02 12:04:02) > Anton Khirnov: > > Quoting Andreas Rheinhardt (2023-09-19 21:56:58) > >> @@ -139,11 +138,7 @@ static int vp8_ref_frame(VP8Context *s, VP8Frame *dst, const VP8Frame *src) > >> > >> if ((ret = ff_thread_ref_frame(&dst->tf, &src->tf)) < 0) > >> return ret; > >> - if (src->seg_map && > >> - !(dst->seg_map = av_buffer_ref(src->seg_map))) { > >> - vp8_release_frame(s, dst); > >> - return AVERROR(ENOMEM); > >> - } > >> + ff_refstruct_replace(&dst->seg_map, src->seg_map); > > > > It seems misleading to use replace rather than ref when dst is clean at > > this point. > > > > This is done with an eye towards 37/42, in which vp8_ref_frame() will be > replaced by vp8_replace_frame(). ah, nevermind then -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".