From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E452047A13 for ; Fri, 29 Sep 2023 09:43:46 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C763268CB9C; Fri, 29 Sep 2023 12:43:43 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0921268CB61 for ; Fri, 29 Sep 2023 12:43:38 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 05D61240490 for ; Fri, 29 Sep 2023 11:43:37 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id mmlpNHWvadBg for ; Fri, 29 Sep 2023 11:43:36 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 4F080240445 for ; Fri, 29 Sep 2023 11:43:36 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 2F4B01601B9; Fri, 29 Sep 2023 11:43:36 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20230928192835.GZ3543730@pb2> References: <20230923164344.GG3543730@pb2> <169589690228.6638.9407962520356451750@lain.khirnov.net> <20230928192835.GZ3543730@pb2> Mail-Followup-To: FFmpeg development discussions and patches Date: Fri, 29 Sep 2023 11:43:36 +0200 Message-ID: <169598061616.6638.4682492428133822842@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] SDR lib comments X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Michael Niedermayer (2023-09-28 21:28:35) > On Thu, Sep 28, 2023 at 12:28:22PM +0200, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2023-09-23 18:43:44) > > > Is a seperate library really the right choice for SDR in FFmpeg at this stage ? > > > > > > Also code can always be moved into an seperate library > > > > we've had postproc in the tree for ages, nobody maintains it or > > cares about it, yet it seems impossible to get rid of it. > > what maintaince does it need ? > i mean i know the code is ugly but what _needs_ to be changed? > > libpostproc implements part of ISO/IEC 14496-2 > (that is the spec for an MPEG-4 ASP decoder) > > its content could be moved in libavfilter and or the mpeg4 decoder > (there are arguments to be made for either) > but it doesnt belong in a lib external to FFmpeg. > (and in the process some bits probably can be droped as they > no longer serve a purpose compared to other filters) > > I have too many other things to work on to do a big refactoring of it > but if there are small bugs in it or questions about it i can look into them The main problem I see with it is that it is a world unto itself. It barely interacts with the rest of the project, its APIs use a different style from everything else, etc. What does anybody gain from it being in our source tree, as opposed to a separate library? -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".