From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 04F9A471C9
	for <ffmpegdev@gitmailbox.com>; Thu, 28 Sep 2023 10:00:42 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1DF5168CB3A;
	Thu, 28 Sep 2023 13:00:41 +0300 (EEST)
Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7C93168CAC8
 for <ffmpeg-devel@ffmpeg.org>; Thu, 28 Sep 2023 13:00:35 +0300 (EEST)
Received: from localhost (localhost [IPv6:::1])
 by mail0.khirnov.net (Postfix) with ESMTP id 454BC240490
 for <ffmpeg-devel@ffmpeg.org>; Thu, 28 Sep 2023 12:00:35 +0200 (CEST)
Received: from mail0.khirnov.net ([IPv6:::1])
 by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP
 id GrZsRsbUalox for <ffmpeg-devel@ffmpeg.org>;
 Thu, 28 Sep 2023 12:00:34 +0200 (CEST)
Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256
 client-signature RSA-PSS (2048 bits) client-digest SHA256)
 (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK))
 by mail0.khirnov.net (Postfix) with ESMTPS id B6196240445
 for <ffmpeg-devel@ffmpeg.org>; Thu, 28 Sep 2023 12:00:34 +0200 (CEST)
Received: by lain.khirnov.net (Postfix, from userid 1000)
 id A19CE1601B9; Thu, 28 Sep 2023 12:00:34 +0200 (CEST)
From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
In-Reply-To: <CAPYw7P4mLHKGnSf6GjNg2-nADy=OB-yL_XNegii-YCf7qG9Ljg@mail.gmail.com>
References: <CAPYw7P7KfEnFGJO=F2-oHKx=p-ARxpsFb7SzdZ8zNUvWAmCyeA@mail.gmail.com>
 <169589387341.6638.15012517934493438253@lain.khirnov.net>
 <CAPYw7P4mLHKGnSf6GjNg2-nADy=OB-yL_XNegii-YCf7qG9Ljg@mail.gmail.com>
Mail-Followup-To: FFmpeg development discussions and patches
 <ffmpeg-devel@ffmpeg.org>
Date: Thu, 28 Sep 2023 12:00:34 +0200
Message-ID: <169589523463.18191.5830002649774141434@lain.khirnov.net>
User-Agent: alot/0.8.1
MIME-Version: 1.0
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/photocd: allow decoding vlc with
 errors
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/169589523463.18191.5830002649774141434@lain.khirnov.net/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

Quoting Paul B Mahol (2023-09-28 11:48:14)
> On 9/28/23, Anton Khirnov <anton@khirnov.net> wrote:
> > Quoting Paul B Mahol (2023-09-27 21:53:54)
> >> Attached.
> >>
> >> From 6b7e51e2b4facead9c45fb94647c85b58e6fdf22 Mon Sep 17 00:00:00 2001
> >> From: Paul B Mahol <onemda@gmail.com>
> >> Date: Wed, 27 Sep 2023 21:48:49 +0200
> >> Subject: [PATCH] avcodec/photocd: allow decoding vlc with errors
> >>
> >> Also rename option that no longer works.
> >> Also make tables finding more robust.
> >
> > Why do all these things in a single patch?
> >
> 
> I can boost my commits if you prefer that way.

Feel welcome.

> >> +            s->streampos = (AV_RB16(avpkt->data + 2048 + 1536 + 3) + 12)
> >> * 2048;
> >
> > Where do these magic numbers come from? Same below.
> 
> From offset from internal image file bitstream table structure.

Please describe that in a comment above that line then.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".