From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/photocd: allow decoding vlc with errors
Date: Thu, 28 Sep 2023 12:00:34 +0200
Message-ID: <169589523463.18191.5830002649774141434@lain.khirnov.net> (raw)
In-Reply-To: <CAPYw7P4mLHKGnSf6GjNg2-nADy=OB-yL_XNegii-YCf7qG9Ljg@mail.gmail.com>
Quoting Paul B Mahol (2023-09-28 11:48:14)
> On 9/28/23, Anton Khirnov <anton@khirnov.net> wrote:
> > Quoting Paul B Mahol (2023-09-27 21:53:54)
> >> Attached.
> >>
> >> From 6b7e51e2b4facead9c45fb94647c85b58e6fdf22 Mon Sep 17 00:00:00 2001
> >> From: Paul B Mahol <onemda@gmail.com>
> >> Date: Wed, 27 Sep 2023 21:48:49 +0200
> >> Subject: [PATCH] avcodec/photocd: allow decoding vlc with errors
> >>
> >> Also rename option that no longer works.
> >> Also make tables finding more robust.
> >
> > Why do all these things in a single patch?
> >
>
> I can boost my commits if you prefer that way.
Feel welcome.
> >> + s->streampos = (AV_RB16(avpkt->data + 2048 + 1536 + 3) + 12)
> >> * 2048;
> >
> > Where do these magic numbers come from? Same below.
>
> From offset from internal image file bitstream table structure.
Please describe that in a comment above that line then.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-09-28 10:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 19:53 Paul B Mahol
2023-09-28 9:37 ` Anton Khirnov
2023-09-28 9:48 ` Paul B Mahol
2023-09-28 10:00 ` Anton Khirnov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169589523463.18191.5830002649774141434@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git