From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Niklas Haas <git@haasn.dev>
Subject: Re: [FFmpeg-devel] [PATCH 1/5] avutil/rational: add av_abs_q
Date: Wed, 27 Sep 2023 12:14:25 +0200
Message-ID: <169580966563.6638.4043160688888230663@lain.khirnov.net> (raw)
In-Reply-To: <20230927100630.50510-2-ffmpeg@haasn.xyz>
Quoting Niklas Haas (2023-09-27 12:03:52)
> +static av_always_inline AVRational av_abs_q(AVRational q)
> +{
> + if (q.num < 0)
> + q.num = -q.num;
> + return q;
What if q.num > 0 and q.den < 0.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-09-27 10:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 10:03 [FFmpeg-devel] [PATCH 0/5] work around broken (apple) ICCv4 profiles Niklas Haas
2023-09-27 10:03 ` [FFmpeg-devel] [PATCH 1/5] avutil/rational: add av_abs_q Niklas Haas
2023-09-27 10:14 ` Anton Khirnov [this message]
2023-09-27 10:22 ` Andreas Rheinhardt
2023-09-27 10:03 ` [FFmpeg-devel] [PATCH 2/5] avutil/csp: re-use av_abs_q Niklas Haas
2023-09-27 10:03 ` [FFmpeg-devel] [PATCH 3/5] avcodec/fflcms2: add ff_icc_profile_sanitize Niklas Haas
2023-09-27 10:20 ` Andreas Rheinhardt
2023-09-27 10:26 ` Niklas Haas
2023-09-27 10:03 ` [FFmpeg-devel] [PATCH 4/5] avfilter/vf_iccdetect: use ff_icc_profile_sanitize Niklas Haas
2023-09-27 10:03 ` [FFmpeg-devel] [PATCH 5/5] avcodec/decode: " Niklas Haas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169580966563.6638.4043160688888230663@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=git@haasn.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git