From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3C7374732C for ; Tue, 5 Sep 2023 11:37:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 86F8B68C733; Tue, 5 Sep 2023 14:37:26 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1E46068C63A for ; Tue, 5 Sep 2023 14:37:20 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id D1FA524018E for ; Tue, 5 Sep 2023 13:37:19 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id o2zz5CbGfekH for ; Tue, 5 Sep 2023 13:37:19 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 1FF99240177 for ; Tue, 5 Sep 2023 13:37:19 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id F29591601B9; Tue, 5 Sep 2023 13:37:18 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20230904150411.56777-2-jamrial@gmail.com> <20230904220848.21900-1-jamrial@gmail.com> <169391205232.20400.15738564387019560241@lain.khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Tue, 05 Sep 2023 13:37:18 +0200 Message-ID: <169391383896.20400.12256334212156878188@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 01/17] avcodec/avcodec: add side data to AVCodecContext X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2023-09-05 13:26:22) > On 9/5/2023 8:07 AM, Anton Khirnov wrote: > > Quoting James Almer (2023-09-05 00:08:48) > >> This will allow the propagation of global side data within the AVCodecContext > >> instead of having to do it inside packets, and thus be available during init(). > >> Global and frame specific side data will therefore be distinct. > > > > This commit message is misleading - there is already > > AVCodecContext.coded_side_data for exactly this purpose. And after the > > changes from the last iteration I see even less of a reason to replace > > it with a new field. > > I insist the new field in the form of a set is better, for the sake of > unified helpers that can be used in avctx, codecpar, avstream, and > potentially others in the future. The big problem with this is that AVPacket is left as is. And since changing it would be a huge break for very little gain, we'll have different handling for packets and everything else for the foreseeable future. I think you'd get almost the same benefits with downsides by making the helpers accept array+count as parameters. It's slightly less elegant, but not hugely so IMO. > It will also be the packet counterpart of Jan's frame side data set > field. coded_side_data is currently used only to export CPB props, so > the amount of users is probably very small (Maybe only lavf, even). I > think the benefits in the long run outweigh the cons from the breakage > that would mean replacing coded_side_data. > > Also, my interpretation of coded is still that it refers to a coded > stream, much like we make a distinction between coded and raw for > bits_per_sample, and in decoding scenarios, side data entries would have > information that refer to the decoded raw stream (hdr, etc). The intent was for it to be a direct counterpart to AVStream.side_data, as is mentioned in the relevant commit message, so your interpretation is objectively wrong. > That said, I don't want to keep delaying this set much longer, so if > you're really against that change I'll try to remove it from the set and > keep the rest. I'd appreciate more opinions on this, from whoever cares. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".