From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B1FD5469FC for ; Fri, 1 Sep 2023 15:51:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 59FC368C6CE; Fri, 1 Sep 2023 18:51:07 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 431D968C589 for ; Fri, 1 Sep 2023 18:51:00 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id C18C024018E for ; Fri, 1 Sep 2023 17:50:58 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id jvwesw-g6Mwk for ; Fri, 1 Sep 2023 17:50:58 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 4A74E240177 for ; Fri, 1 Sep 2023 17:50:58 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 3943A1601B9; Fri, 1 Sep 2023 17:50:56 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20230826122328.95416-1-stefasab@gmail.com> <169306293626.20400.4712343328864304301@lain.khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Fri, 01 Sep 2023 17:50:56 +0200 Message-ID: <169358345620.20400.6777068619760269139@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] lsws/swscale.h: introduce sws_get_gaussian_vec X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Stefano Sabatini (2023-08-31 17:06:06) > On date Saturday 2023-08-26 17:15:36 +0200, Anton Khirnov wrote: > > Quoting Stefano Sabatini (2023-08-26 14:23:28) > > > Use in place of sws_getGaussianVec. > > > > > > The new function enable better log handling, and provide better naming > > > for the variance variable, now named standard_deviation to reflect the > > > meaning of the parameter. > > > > > Logging to NULL does not seem like an improvement to me. > > Adding the log_ctx. > > > Renaming a function parameter does not require an API break. > > The main point was improving the naming of the variable, but while at > it I'm also adding the logging context and providing a return code to > specify an error failure, and moving to snake_case convention which is > the one used by the new API additions. As I already said above - function parameter names in a prototype are purely cosmetic and have no effect on anything besides doxygen. You can change them at will and even remove them entirely without breaking API or ABI. The other reasons do not strike me as strong enough to warrant an API break. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".