* [FFmpeg-devel] [PATCH] fftools/ffmpeg_mux_init: fix an array declaration
@ 2023-07-16 8:29 Anton Khirnov
2023-07-16 8:50 ` Rémi Denis-Courmont
0 siblings, 1 reply; 2+ messages in thread
From: Anton Khirnov @ 2023-07-16 8:29 UTC (permalink / raw)
To: ffmpeg-devel
map_func is supposed to be an array of const pointer to function
returning int, not an array of pointer to function returning const int.
Reported-By: Martin Storsjö
---
fftools/ffmpeg_mux_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c
index 6458414b5f..c2630dd893 100644
--- a/fftools/ffmpeg_mux_init.c
+++ b/fftools/ffmpeg_mux_init.c
@@ -1648,7 +1648,7 @@ read_fail:
static int create_streams(Muxer *mux, const OptionsContext *o)
{
- static const int (*map_func[])(Muxer *mux, const OptionsContext *o) = {
+ static int (* const map_func[])(Muxer *mux, const OptionsContext *o) = {
[AVMEDIA_TYPE_VIDEO] = map_auto_video,
[AVMEDIA_TYPE_AUDIO] = map_auto_audio,
[AVMEDIA_TYPE_SUBTITLE] = map_auto_subtitle,
--
2.40.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_mux_init: fix an array declaration
2023-07-16 8:29 [FFmpeg-devel] [PATCH] fftools/ffmpeg_mux_init: fix an array declaration Anton Khirnov
@ 2023-07-16 8:50 ` Rémi Denis-Courmont
0 siblings, 0 replies; 2+ messages in thread
From: Rémi Denis-Courmont @ 2023-07-16 8:50 UTC (permalink / raw)
To: ffmpeg-devel
Le sunnuntaina 16. heinäkuuta 2023, 11.29.34 EEST Anton Khirnov a écrit :
> map_func is supposed to be an array of const pointer to function
> returning int, not an array of pointer to function returning const int.
>
> Reported-By: Martin Storsjö
> ---
> fftools/ffmpeg_mux_init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c
> index 6458414b5f..c2630dd893 100644
> --- a/fftools/ffmpeg_mux_init.c
> +++ b/fftools/ffmpeg_mux_init.c
> @@ -1648,7 +1648,7 @@ read_fail:
>
> static int create_streams(Muxer *mux, const OptionsContext *o)
> {
> - static const int (*map_func[])(Muxer *mux, const OptionsContext *o) = {
> + static int (* const map_func[])(Muxer *mux, const OptionsContext *o) =
> { [AVMEDIA_TYPE_VIDEO] = map_auto_video,
> [AVMEDIA_TYPE_AUDIO] = map_auto_audio,
> [AVMEDIA_TYPE_SUBTITLE] = map_auto_subtitle,
LGTM
--
Rémi Denis-Courmont
http://www.remlab.net/
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-16 8:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-16 8:29 [FFmpeg-devel] [PATCH] fftools/ffmpeg_mux_init: fix an array declaration Anton Khirnov
2023-07-16 8:50 ` Rémi Denis-Courmont
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git