From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2819C46539 for ; Thu, 20 Jul 2023 19:08:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 07F1968C5AA; Thu, 20 Jul 2023 22:08:31 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E5F8C68C187 for ; Thu, 20 Jul 2023 22:08:24 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 9E09F2404EC for ; Thu, 20 Jul 2023 21:08:24 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id NG6G8mr4yzMJ for ; Thu, 20 Jul 2023 21:08:24 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 1DC282404EA for ; Thu, 20 Jul 2023 21:08:24 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 0107F1601B2; Thu, 20 Jul 2023 21:08:23 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20230719222043.59743-5-jamrial@gmail.com> References: <20230719222043.59743-1-jamrial@gmail.com> <20230719222043.59743-5-jamrial@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Thu, 20 Jul 2023 21:08:23 +0200 Message-ID: <168988010396.27367.2360099703316632165@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 5/5] fftools/ffmpeg: support applying container level cropping X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2023-07-20 00:20:43) > diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c > index 8b750de4e5..3cf29c8b2c 100644 > --- a/fftools/ffmpeg_enc.c > +++ b/fftools/ffmpeg_enc.c > @@ -441,14 +441,16 @@ int enc_open(OutputStream *ost, AVFrame *frame) > int i; > for (i = 0; i < ist->st->nb_side_data; i++) { > AVPacketSideData *sd = &ist->st->side_data[i]; > - if (sd->type != AV_PKT_DATA_CPB_PROPERTIES) { > + if (sd->type == AV_PKT_DATA_CPB_PROPERTIES) > + continue; > + if (ist->apply_cropping && sd->type == AV_PKT_DATA_FRAME_CROPPING) > + continue; I'm very much not a fan of the encoder doing anything based on decoder options. I know the code below already does the same thing, but I'd like to get rid of it rather than add to it. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".