Re: [FFmpeg-devel] [PATCH 0/3] avcodec: move HDR10 (MDCV/CLL) SEI handling to h2645_sei

From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 0/3] avcodec: move HDR10 (MDCV/CLL) SEI handling to h2645_sei
Date: Thu, 20 Jul 2023 21:06:36 +0200
Message-ID: <168987999634.27367.7949769279676648813@lain.khirnov.net> (raw)
In-Reply-To: <20230712183252.302971-1-jeebjp@gmail.com>

Quoting Jan Ekström (2023-07-12 20:32:44)
> This allows parsing code to be re-utilized from H.264, as well as probably
> from VVC in the future.
> 
> This additionally eases verification of the AVCodecContext side data patch
> set, which includes libx264 integration for HDR10 side data.
> 
> Notes: 
> * At least in ffprobe and FATE tests the code works even without the additional
>   sync in "update_thread_context" in either HEVC or H.264 (as the viewing
>   environment SEI patch set showed earlier). As the current HEVC code had such
>   sync, I kept it and added a similar thing to the H.264 decoder.
> ** If this is required for all things, the sync should possibly be added to
>    ff_h2645_sei_ctx_replace? As currently both the HEVC and H.264 decoders are
>    synchronizing various structs by themselves in addition to calling
>    ctx_replace.

Is it supposed to apply to the current frame only or all the following
ones as well. If the latter, you need to propagate it between thread
contexts.

> * I did not add a simlar decrementing logic to the H.264 decoder for now,
>   as not sure how it should be handled exactly.

Not sure what you mean by decrementing - what is being decremented?

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".