From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 201C040929 for ; Fri, 14 Jul 2023 09:07:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3B1D668C60B; Fri, 14 Jul 2023 12:07:27 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B714368C4C9 for ; Fri, 14 Jul 2023 12:07:20 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 27B0B2404EC for ; Fri, 14 Jul 2023 11:07:20 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id kYgy3Qj2B-SP for ; Fri, 14 Jul 2023 11:07:19 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 5F54D2404EA for ; Fri, 14 Jul 2023 11:07:19 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 3EA651601B2; Fri, 14 Jul 2023 11:07:19 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20230713233024.GL1093384@pb2> References: <20230713105553.21052-1-anton@khirnov.net> <20230713105553.21052-16-anton@khirnov.net> <20230713233024.GL1093384@pb2> Mail-Followup-To: FFmpeg development discussions and patches Date: Fri, 14 Jul 2023 11:07:19 +0200 Message-ID: <168932563922.27367.17493759052457548791@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 16/33] fftools/ffmpeg_mux_init: improve of_add_programs() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Michael Niedermayer (2023-07-14 01:30:24) > On Thu, Jul 13, 2023 at 12:55:36PM +0200, Anton Khirnov wrote: > > Replace duplicated(!) and broken* custom string parsing with > > av_dict_parse_string(). Return error codes instead of aborting. > > > > * e.g. it treats NULL returned from av_get_token() as "separator not > > found", when in fact av_get_token() only returns NULL on memory > > allocation failure > > --- > > fftools/ffmpeg_mux_init.c | 111 ++++++++++++++++++-------------------- > > 1 file changed, 52 insertions(+), 59 deletions(-) > > smells like memory corruption > > -i ~/videos/01c56b0dc1.ts -copy_unknown -map 0 -c copy -fflags +bitexact -t 3 -y file-copy-unknown.ts I have no idea why are you replying to this specific patch, when this issue apparently exists in current master. I'll send a fix for it in a later patchset, but it's completely unrelated to this set. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".