Re: [FFmpeg-devel] [PATCH 01/33] fftools/ffmpeg_mux_init: return errors from of_open() instead of aborting

From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 01/33] fftools/ffmpeg_mux_init: return errors from of_open() instead of aborting
Date: Thu, 13 Jul 2023 15:01:13 +0200
Message-ID: <168925327345.27367.7514791467370308227@lain.khirnov.net> (raw)
In-Reply-To: <tencent_2B9645CD74A046CDB44FF1D55BA70D38A307@qq.com>

Quoting zhilizhao(赵志立) (2023-07-13 14:01:48)
> 
> 
> > On Jul 13, 2023, at 18:55, Anton Khirnov <anton@khirnov.net> wrote:
> > 
> > ---
> > fftools/ffmpeg_mux_init.c | 16 ++++++++--------
> > 1 file changed, 8 insertions(+), 8 deletions(-)
> > 
> > diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c
> > index 6ab541d7c5..8a3e7b98cf 100644
> > --- a/fftools/ffmpeg_mux_init.c
> > +++ b/fftools/ffmpeg_mux_init.c
> > @@ -2380,7 +2380,7 @@ int of_open(const OptionsContext *o, const char *filename)
> >         int64_t start_time = o->start_time == AV_NOPTS_VALUE ? 0 : o->start_time;
> >         if (stop_time <= start_time) {
> >             av_log(mux, AV_LOG_ERROR, "-to value smaller than -ss; aborting.\n");
> > -            exit_program(1);
> > +            return AVERROR(EINVAL);
> 
> The log message still says ‘aborting’.

From the user's POV it does abort the transcoding, so the message is IMO
still accurate. The change is only in how precisely the abort is done.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".