From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E482F45DDA for ; Wed, 12 Jul 2023 13:28:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AE7E668C582; Wed, 12 Jul 2023 16:28:10 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E528368C4F4 for ; Wed, 12 Jul 2023 16:28:03 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id A18132404EC for ; Wed, 12 Jul 2023 15:28:03 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id Nvbu9baX2cbT for ; Wed, 12 Jul 2023 15:28:03 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 253B42404EA for ; Wed, 12 Jul 2023 15:28:03 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 0B94D1601B2; Wed, 12 Jul 2023 15:28:03 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <226586ee-0d56-2d14-484f-3d2057582867@gmail.com> References: <20230712020644.22606-1-jamrial@gmail.com> <168915281618.27367.2912618442323999928@lain.khirnov.net> <226586ee-0d56-2d14-484f-3d2057582867@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Wed, 12 Jul 2023 15:28:03 +0200 Message-ID: <168916848301.27367.7698381858904050174@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/decode: don't reject flush packets when buffer_pkt is not empty X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2023-07-12 13:30:30) > On 7/12/2023 6:06 AM, Anton Khirnov wrote: > > Quoting James Almer (2023-07-12 04:06:43) > >> Restores the behavior pre commit a92dbeb9ae. > >> > >> Signed-off-by: James Almer > > > > Do you see any advantage to this? > > Not returning an error when a flush packet is feed to the decoder. Why > would the API force me to retrieve frames before i can tell it I'm not > going to feed it any more packets? Right, I guess that makes sense. We should document this behaviour explicitly though, if we're bothering to maintain it. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".