From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/internal: Move AVCodecInternal to a header of its own
Date: Tue, 11 Jul 2023 12:13:16 +0200
Message-ID: <168907039655.27367.6593832128550408622@lain.khirnov.net> (raw)
In-Reply-To: =?utf-8?q?=3CGV1P250MB07375D3E989DC408630724448F31A=40GV1P250MB?= =?utf-8?q?0737=2EEURP250=2EPROD=2EOUTLOOK=2ECOM=3E?=
Quoting Andreas Rheinhardt (2023-07-11 03:10:38)
> This allows to avoid exposing AVCodecInternal to files that
> don't need it and only include internal.h for something else
> (like the avpriv functions which are of course included outside
> of libavcodec where AVCodecInternal should never be visible).
Actually looking at all those other things in internal.h it seems to me
that (almost?) all of them belong somewhere else.
Multiple functions are only used in one place, some others are
encoding-only and belong in encode.h, etc.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev reply other threads:[~2023-07-11 10:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 1:10 Andreas Rheinhardt
2023-07-11 1:15 ` James Almer
2023-07-11 1:26 ` Andreas Rheinhardt
2023-07-11 1:32 ` James Almer
2023-07-11 10:13 ` Anton Khirnov [this message]
2023-08-02 15:37 ` Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168907039655.27367.6593832128550408622@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git