From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9C52E46D12 for ; Sun, 9 Jul 2023 12:59:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AB36168C640; Sun, 9 Jul 2023 15:59:05 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 52EDD68C44A for ; Sun, 9 Jul 2023 15:58:59 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id E094B2404EC for ; Sun, 9 Jul 2023 14:58:58 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id 0kbDDbyc7rtF for ; Sun, 9 Jul 2023 14:58:58 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 61C252404EA for ; Sun, 9 Jul 2023 14:58:58 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 4EF561601B2; Sun, 9 Jul 2023 14:58:58 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20230708190038.24324-1-jamrial@gmail.com> <20230708190038.24324-3-jamrial@gmail.com> <168889619587.542.7376351668865015515@lain.khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Sun, 09 Jul 2023 14:58:58 +0200 Message-ID: <168890753828.542.5646653542160399356@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 3/3] avcodec/decode: fill missing frame fields for all decoders X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2023-07-09 14:05:45) > On 7/9/2023 6:49 AM, Anton Khirnov wrote: > > Quoting James Almer (2023-07-08 21:00:38) > >> And not just those with the old decode() API. > >> > >> Signed-off-by: James Almer > >> --- > >> libavcodec/decode.c | 52 +++++++++++++++++++++++---------------------- > >> 1 file changed, 27 insertions(+), 25 deletions(-) > > > > Is there a functional reason for this patch? > > > > I've been wondering recently about dropping this code entirely, because > > get_buffer() should always fill those fields. > > Decoders that don't use get_buffer at all exist. If they don't fill all > frame fields, this would. Ah well, there's more of those than I thought. No objections then. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".