From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 3/3] avcodec/decode: fill missing frame fields for all decoders
Date: Sun, 09 Jul 2023 14:58:58 +0200
Message-ID: <168890753828.542.5646653542160399356@lain.khirnov.net> (raw)
In-Reply-To: <f583d9ec-bd97-f31a-3913-ee3fb739595c@gmail.com>
Quoting James Almer (2023-07-09 14:05:45)
> On 7/9/2023 6:49 AM, Anton Khirnov wrote:
> > Quoting James Almer (2023-07-08 21:00:38)
> >> And not just those with the old decode() API.
> >>
> >> Signed-off-by: James Almer <jamrial@gmail.com>
> >> ---
> >> libavcodec/decode.c | 52 +++++++++++++++++++++++----------------------
> >> 1 file changed, 27 insertions(+), 25 deletions(-)
> >
> > Is there a functional reason for this patch?
> >
> > I've been wondering recently about dropping this code entirely, because
> > get_buffer() should always fill those fields.
>
> Decoders that don't use get_buffer at all exist. If they don't fill all
> frame fields, this would.
Ah well, there's more of those than I thought.
No objections then.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-07-09 12:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-08 19:00 [FFmpeg-devel] [PATCH 1/3] avcodec/decode: move processing discard samples to its own function James Almer
2023-07-08 19:00 ` [FFmpeg-devel] [PATCH 2/3] avcodec/decode: check the output frame for discard samples with all decoders James Almer
2023-07-08 19:00 ` [FFmpeg-devel] [PATCH 3/3] avcodec/decode: fill missing frame fields for " James Almer
2023-07-09 9:49 ` Anton Khirnov
2023-07-09 12:05 ` James Almer
2023-07-09 12:58 ` Anton Khirnov [this message]
2023-07-08 19:38 ` [FFmpeg-devel] [PATCH 1/3] avcodec/decode: move processing discard samples to its own function Andreas Rheinhardt
2023-07-08 19:41 ` James Almer
2023-07-09 9:48 ` Anton Khirnov
2023-07-09 12:11 ` James Almer
2023-07-09 12:15 ` Anton Khirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168890753828.542.5646653542160399356@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git