From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 05C9E45D8A for ; Sun, 9 Jul 2023 02:18:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BD1CF68C56A; Sun, 9 Jul 2023 05:18:54 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2653768C288 for ; Sun, 9 Jul 2023 05:18:48 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 5FDDC2404EC for ; Sun, 9 Jul 2023 04:18:47 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id C1CEm5b4yrbu for ; Sun, 9 Jul 2023 04:18:46 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id C88A82404EA for ; Sun, 9 Jul 2023 04:18:46 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id B5F141601B2; Sun, 9 Jul 2023 04:18:46 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20230708221530.GC1093384@pb2> References: <20230707094847.25324-1-anton@khirnov.net> <20230707094847.25324-13-anton@khirnov.net> <20230708221530.GC1093384@pb2> Mail-Followup-To: FFmpeg development discussions and patches Date: Sun, 09 Jul 2023 04:18:46 +0200 Message-ID: <168886912670.9711.17813877648864018683@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 13/22] fftools/ffmpeg_filter: stop disregarding user-specified pixel format X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Michael Niedermayer (2023-07-09 00:15:30) > On Fri, Jul 07, 2023 at 11:48:38AM +0200, Anton Khirnov wrote: > > When the user explicitly specifies a pixel format that is not supported > > by the encoder, ffmpeg CLI will currently use some heuristics to pick > > another supported format. This is wrong and the correct action here is > > to fail. > > > > Surprisingly, a number of FATE tests are affected by this and actually > > use a different pixel format than is specified in the makefiles. > > --- > > fftools/ffmpeg_filter.c | 36 ++----------------- > > tests/fate/fits.mak | 6 ++-- > > tests/fate/lavf-video.mak | 2 +- > > tests/fate/vcodec.mak | 4 +-- > > .../{fitsdec-gbrap16le => fitsdec-gbrap16be} | 4 +-- > > .../fate/{fitsdec-gbrp16 => fitsdec-gbrp16be} | 4 +-- > > tests/ref/lavf/gif | 2 +- > > 7 files changed, 13 insertions(+), 45 deletions(-) > > rename tests/ref/fate/{fitsdec-gbrap16le => fitsdec-gbrap16be} (79%) > > rename tests/ref/fate/{fitsdec-gbrp16 => fitsdec-gbrp16be} (79%) > > breaks png > > ./ffmpeg -y -i lena.pnm -s 696x300 -pix_fmt rgb48 -y out2.png > > Error while opening encoder - maybe incorrect parameters such as bit_rate, rate, width or height. > Conversion failed! > > before > ./ffprobe out2.png > ... > Stream #0:0: Video: png, rgb48be(pc, gbr/unknown/unknown), 696x300, 25 fps, 25 tbr, 25 tbn > > Yes internally its BE vs LE but thats not what the user wrote on the command line The pixel format that is printed in your "before" is different from what the user wrote as well, so the new behavior is correct IMO. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".