From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3931D46BB6 for ; Tue, 4 Jul 2023 20:14:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A2E2F68C62E; Tue, 4 Jul 2023 23:14:10 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3B3D068C628 for ; Tue, 4 Jul 2023 23:14:04 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id E593F2404EC for ; Tue, 4 Jul 2023 22:14:03 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id 9Sec3IZhIlDl for ; Tue, 4 Jul 2023 22:14:03 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 573112404EA for ; Tue, 4 Jul 2023 22:14:03 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 3A39C1601B2; Tue, 4 Jul 2023 22:14:03 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <015b4860-af67-5d23-2cd2-eac877d38df7@gmail.com> References: <20230704185044.2154-1-jamrial@gmail.com> <5a79a98-acb9-62bc-5279-e3624fc3c5@passwd.hu> <78fb24a6-831e-e38e-1064-a9e316d8fea6@gmail.com> <168850077133.542.4969284195602855710@lain.khirnov.net> <015b4860-af67-5d23-2cd2-eac877d38df7@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Tue, 04 Jul 2023 22:14:03 +0200 Message-ID: <168850164319.9711.14148902878362607430@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 1/2] avutil/random_seed: add av_random() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2023-07-04 22:08:40) > On 7/4/2023 4:59 PM, Anton Khirnov wrote: > >> > >> Not if any of the functions above were called but failed to fill the buffer. > >> > >> I could add return AVERROR(ENOSYS) to the HAVE_UNISTD_H block, and > >> return AVERROR_INVALIDDATA outside. > > > > AVERROR_INVALIDDATA is defined as 'Invalid data found when processing > > input'. > > This function does not process any input, so IMO that code never makes > > sense for it. > > > > I'd say make it ENOSYS, AVERROR_UNKNOWN, or keep around one of > > individual method errors. > > For the cases read() is used for /dev/random/, i can return > AVERROR(errno), given the doxy states read() returns -1 on error and > sets errno to some value. Although if it succeeds and returns a value > smaller than len i would need to return AVERROR_UNKNOWN like you suggested. I wonder if we should be trying /dev/random at all. I cannot think of any remotely sane configuration where /dev/urandom fails, but /dev/random works. So it only makes sense to use /dev/urandom. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".