From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/2] avutil/random_seed: add av_random()
Date: Tue, 04 Jul 2023 21:59:31 +0200
Message-ID: <168850077133.542.4969284195602855710@lain.khirnov.net> (raw)
In-Reply-To: <78fb24a6-831e-e38e-1064-a9e316d8fea6@gmail.com>
>
> Not if any of the functions above were called but failed to fill the buffer.
>
> I could add return AVERROR(ENOSYS) to the HAVE_UNISTD_H block, and
> return AVERROR_INVALIDDATA outside.
AVERROR_INVALIDDATA is defined as 'Invalid data found when processing
input'.
This function does not process any input, so IMO that code never makes
sense for it.
I'd say make it ENOSYS, AVERROR_UNKNOWN, or keep around one of
individual method errors.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-07-04 19:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 18:50 James Almer
2023-07-04 18:50 ` [FFmpeg-devel] [PATCH 2/2] avutil/random_seed: ass support for gcrypt and OpenSSL as source of randomness James Almer
2023-07-04 20:02 ` Marton Balint
2023-07-04 20:07 ` James Almer
2023-07-04 19:34 ` [FFmpeg-devel] [PATCH 1/2] avutil/random_seed: add av_random() Marton Balint
2023-07-04 19:42 ` James Almer
2023-07-04 19:59 ` Anton Khirnov [this message]
2023-07-04 20:08 ` James Almer
2023-07-04 20:14 ` Anton Khirnov
2023-07-04 20:18 ` James Almer
2023-07-04 20:24 ` Anton Khirnov
2023-07-04 20:14 ` Anton Khirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168850077133.542.4969284195602855710@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git