From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 31FDC46B3A for ; Mon, 3 Jul 2023 17:18:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EFBC468C591; Mon, 3 Jul 2023 20:17:32 +0300 (EEST) Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6312568C56F for ; Mon, 3 Jul 2023 20:17:23 +0300 (EEST) Received: by mail-ot1-f54.google.com with SMTP id 46e09a7af769-6b73c2b6dcfso2763976a34.2 for ; Mon, 03 Jul 2023 10:17:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ltnglobal-com.20221208.gappssmtp.com; s=20221208; t=1688404641; x=1690996641; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=zYMZkBFpngcwpgJtMBlooWpLtOEW0p/mrRDmFW50WS0=; b=CB1LotPxiMegZXLTRbhVPF5EzMhRyeBm6ZdFW1graf2PdIUwe1nqEezcHBQn5h8AWq Ja8+CiuUDW4Gc/uKWLAbpmv31pSZ9uzQGZyxuYtorCb/DVSa7q55dpVhbjYQt0goHS6L W1NKjwr/YXqeMHSaghgUs20C7KmwQ2dsRxsFPt7tlEc83pahcmUXdxVoPRnHPZcK9Qo9 z915uI1dXJd/T8IQo/NyMRKYXNDEZkKoX7ReEah9PxaY7H8opAmoNKFtptm13u00Ok2E cQ7MfMoz2CucWm6SNJl+fXK9lMwltktAaGGtZh/nFeUawj7quBhuhTqzufLyn2MJQeBW 2yhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688404641; x=1690996641; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zYMZkBFpngcwpgJtMBlooWpLtOEW0p/mrRDmFW50WS0=; b=iX+adptF6SUCp6oWBEW1SSfQdN8/XkNaBpLO4ZKHOsYWHZz+4XZE+R/KAtBjEAHE4E MWkr+ESlBCohmvgijtXOM/mg5hw6k4ZGBnmrI+bvztku8iTNgf9VYuVQqymQms+NywYd ijL4xz5HXEFPe+QBm5PYXEIUqhz/ai96nWJXLoK7sgzkkRVLL+VA4FWvma1HR1Vhj5WD NX4qnkjzwhAFooWz7XMwkhApb05jNHYkB/vEmYqxIy37lFEFVam3zC+KQBzyZCt75kOb 3K97MqgUdvshUPdT7inShTYdtFywxotCzHw9myxHKMBJAUhpxPyxJtZAp4/VAGgUJflt AuQQ== X-Gm-Message-State: AC+VfDyfYyQQ2/YLu2g3ahg4gzGjs0WNzzSbO32P6eIU28Jc0r3d+KrN ih0SIalXCdIMLF/Z7HC9Y0TjemzjACAfKnnsUTI= X-Google-Smtp-Source: ACHHUZ7sWfjrzp5YA5nIVCx4KPJMI7IiwgB0hXKiV72yh9BogoR76wi9BKTI3E2fU2UsF5/dNLNgAw== X-Received: by 2002:a9d:7456:0:b0:6af:79e7:2e29 with SMTP id p22-20020a9d7456000000b006af79e72e29mr8334503otk.15.1688404641477; Mon, 03 Jul 2023 10:17:21 -0700 (PDT) Received: from ltnt-nyc-580testdevin.livetimenet.com (pool-71-105-132-214.nycmny.fios.verizon.net. [71.105.132.214]) by smtp.gmail.com with ESMTPSA id m20-20020ac85b14000000b003f6c9f8f0a8sm8730193qtw.68.2023.07.03.10.17.20 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Jul 2023 10:17:21 -0700 (PDT) From: Devin Heitmueller X-Google-Original-From: Devin Heitmueller To: ffmpeg-devel@ffmpeg.org Date: Mon, 3 Jul 2023 14:15:08 -0400 Message-Id: <1688408109-14381-5-git-send-email-dheitmueller@ltnglobal.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1688408109-14381-1-git-send-email-dheitmueller@ltnglobal.com> References: <1688408109-14381-1-git-send-email-dheitmueller@ltnglobal.com> Subject: [FFmpeg-devel] [PATCH v2 4/5] mpegtsenc: Don't periodically announce PCR on SCTE-35 streams X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Devin Heitmueller MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Changes were made between in the last two years to periodically send PCR-only packets on all PIDs, but for cases where the stream may send packets very infrequently (like SCTE-35), this results in extra TR101290 errors because it fails the PCR interval test. I am not quite sure what the "right" fix should be for this, but for now just disable all periodic sending of PCR-only packets on SCTE-35 streams. Signed-off-by: Devin Heitmueller --- libavformat/mpegtsenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index c6cd1fd..ba60582 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegtsenc.c @@ -1579,7 +1579,7 @@ static void mpegts_write_pes(AVFormatContext *s, AVStream *st, int st2_index = i < st->index ? i : (i + 1 == s->nb_streams ? st->index : i + 1); AVStream *st2 = s->streams[st2_index]; MpegTSWriteStream *ts_st2 = st2->priv_data; - if (ts_st2->pcr_period) { + if (ts_st2->pcr_period && st2->codecpar->codec_id != AV_CODEC_ID_SCTE_35) { if (pcr - ts_st2->last_pcr >= ts_st2->pcr_period) { ts_st2->last_pcr = FFMAX(pcr - ts_st2->pcr_period, ts_st2->last_pcr + ts_st2->pcr_period); if (st2 != st) { -- 1.8.3.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".