From: "Rémi Denis-Courmont" <remi@remlab.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v3 1/4] avcodec/bswapdsp: remove unused cextern
Date: Fri, 13 Jan 2023 22:04:25 +0200
Message-ID: <1688363.0KRhXFXEzc@basile.remlab.net> (raw)
In-Reply-To: <CA+anCRn9JtH6qLO0QyE2fpWhTQXF+J1cxmbt2x0XDShjz-zKxg@mail.gmail.com>
Le keskiviikkona 11. tammikuuta 2023, 0.57.13 EET Mark Reid a écrit :
> > Are you really duplicating a whole bunch of files from lavc in sws? I
> > don't think that's anywhere remotely close to acceptable.
>
> This was what I was suggested to do
> http://ffmpeg.org/pipermail/ffmpeg-devel/2022-December/304667.html
TBH, you do not need to duplicate the source to have the same code statically
linked in two different libraries. At most, you need some macro to rename the
functions to avoid duplicate symbols in the odd case that swscale and lavc are
statically linked into the same shared object. (I do not personally like that
coding style, but it seems quite popular in FFmpeg already.)
I agree with Anton that duplicating the complete source does not seem
acceptable (especially if *I* am expected to fix the RISC-V afterwards, but I
digress).
--
Реми Дёни-Курмон
http://www.remlab.net/
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-01-13 20:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 2:42 mindmark
2022-12-13 2:42 ` [FFmpeg-devel] [PATCH v3 2/4] avcodec/bswapdsp: rename bswap_buf to bswap_buf32 mindmark
2022-12-13 2:42 ` [FFmpeg-devel] [PATCH v3 3/4] avcodec/bswapdsp: add documentation mindmark
2022-12-13 2:42 ` [FFmpeg-devel] [PATCH v3 4/4] swscale/bswapdsp: copy over bswapdsp from avcodec mindmark
2022-12-26 21:31 ` [FFmpeg-devel] [PATCH v3 1/4] avcodec/bswapdsp: remove unused cextern Mark Reid
2023-01-06 18:09 ` Mark Reid
2023-01-10 11:07 ` Anton Khirnov
2023-01-10 22:57 ` Mark Reid
2023-01-13 20:04 ` Rémi Denis-Courmont [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1688363.0KRhXFXEzc@basile.remlab.net \
--to=remi@remlab.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git