From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 01FE5469C1 for ; Sat, 1 Jul 2023 08:12:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 44FFA68C02A; Sat, 1 Jul 2023 11:12:02 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 592FF68B3CA for ; Sat, 1 Jul 2023 11:11:55 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 950452404EC; Sat, 1 Jul 2023 10:11:54 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id F1lnQk2wh9IV; Sat, 1 Jul 2023 10:11:54 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id F37A52404EA; Sat, 1 Jul 2023 10:11:53 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id CDBDA1601B2; Sat, 1 Jul 2023 10:11:53 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <1688161135-11774-4-git-send-email-dheitmueller@ltnglobal.com> References: <1688161135-11774-1-git-send-email-dheitmueller@ltnglobal.com> <1688161135-11774-4-git-send-email-dheitmueller@ltnglobal.com> Mail-Followup-To: FFmpeg development discussions and patches , Devin Heitmueller Date: Sat, 01 Jul 2023 10:11:53 +0200 Message-ID: <168819911380.21886.2308739362539561164@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v2 3/7] avcodec/avframe: add new side data types for Bar Data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Devin Heitmueller Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Devin Heitmueller (2023-06-30 23:38:51) > Add new side data types for both AVPacket and AVFrame to support > "bar data" as defined in SMPTE 2016-1, ATSC A/53, and SCTE 128-1. > > Signed-off-by: Devin Heitmueller > --- > libavcodec/decode.c | 1 + > libavcodec/defs.h | 12 ++++++++++++ > libavcodec/packet.h | 6 ++++++ > libavutil/frame.h | 6 ++++++ > 4 files changed, 25 insertions(+) > > diff --git a/libavcodec/decode.c b/libavcodec/decode.c > index 6ee2c85..5aafce7 100644 > --- a/libavcodec/decode.c > +++ b/libavcodec/decode.c > @@ -1332,6 +1332,7 @@ int ff_decode_frame_props_from_pkt(const AVCodecContext *avctx, > { AV_PKT_DATA_CONTENT_LIGHT_LEVEL, AV_FRAME_DATA_CONTENT_LIGHT_LEVEL }, > { AV_PKT_DATA_A53_CC, AV_FRAME_DATA_A53_CC }, > { AV_PKT_DATA_AFD, AV_FRAME_DATA_AFD }, > + { AV_PKT_DATA_BARDATA, AV_FRAME_DATA_BARDATA }, > { AV_PKT_DATA_ICC_PROFILE, AV_FRAME_DATA_ICC_PROFILE }, > { AV_PKT_DATA_S12M_TIMECODE, AV_FRAME_DATA_S12M_TIMECODE }, > { AV_PKT_DATA_DYNAMIC_HDR10_PLUS, AV_FRAME_DATA_DYNAMIC_HDR_PLUS }, > diff --git a/libavcodec/defs.h b/libavcodec/defs.h > index fbe3254..deadfe7 100644 > --- a/libavcodec/defs.h > +++ b/libavcodec/defs.h > @@ -119,6 +119,18 @@ typedef struct AVPanScan { > } AVPanScan; > > /** > + * Bar data - used by side data for avcodec and avframe. Defines the location > + * of horizontal or vertical black bars (i.e. letterbox/pillar bars) > + */ > +typedef struct AVBarData { > + int top_bottom; /* 0=top/bottom 1=left/right */ > + int top; > + int left; > + int bottom; > + int right; Am I understanding correctly that half of these are never used for a given AVBarData instance? Seems wasteful. Could make it a generic bound0, bound1 or a union instead. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".