From: Anton Khirnov <anton@khirnov.net>
To: "ffmpeg-devel@ffmpeg.org" <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2] avformat/ivfenc: Set the "number of frames" in IVF header
Date: Wed, 28 Jun 2023 17:24:59 +0200
Message-ID: <168796589909.21886.12641050031611059268@lain.khirnov.net> (raw)
In-Reply-To: =?utf-8?q?=3CDM6PR11MB26814011FF82B8637DF846B7B14DA=40DM6PR11MB?= =?utf-8?q?2681=2Enamprd11=2Eprod=2Eoutlook=2Ecom=3E?=
Quoting Dai, Jianhui J (2023-06-05 02:53:35)
> diff --git a/libavformat/ivfdec.c b/libavformat/ivfdec.c
> index 511f2387ed..01012db948 100644
> --- a/libavformat/ivfdec.c
> +++ b/libavformat/ivfdec.c
> @@ -53,6 +53,7 @@ static int read_header(AVFormatContext *s)
> st->codecpar->height = avio_rl16(s->pb);
> time_base.den = avio_rl32(s->pb);
> time_base.num = avio_rl32(s->pb);
> + // Infer duration from "number of frames".
> st->duration = avio_rl32(s->pb);
This should be setting st->nb_frames then rather than duration.
And the muxer should be using that field as well instead of its custom
version.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev reply other threads:[~2023-06-28 15:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 0:53 Dai, Jianhui J
2023-06-20 1:42 ` Dai, Jianhui J
2023-06-28 15:24 ` Anton Khirnov [this message]
2023-06-29 6:03 ` Dai, Jianhui J
2023-06-29 9:44 ` Anton Khirnov
2023-07-02 0:03 ` Ronald S. Bultje
2023-07-02 9:35 ` Anton Khirnov
2023-07-02 12:44 ` Ronald S. Bultje
2023-07-02 12:58 ` Anton Khirnov
2023-07-02 14:41 ` Ronald S. Bultje
2023-07-03 2:48 ` Dai, Jianhui J
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168796589909.21886.12641050031611059268@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git