From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 32AB240807 for ; Mon, 26 Jun 2023 16:08:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BC58E68C2A6; Mon, 26 Jun 2023 19:08:53 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5AA2B68C062 for ; Mon, 26 Jun 2023 19:08:47 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id DE5CB2404EC for ; Mon, 26 Jun 2023 18:08:46 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id MqHbSPCQvz-N for ; Mon, 26 Jun 2023 18:08:46 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 33F4F2404EA for ; Mon, 26 Jun 2023 18:08:46 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 0FB2E1601B2; Mon, 26 Jun 2023 18:08:46 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20230626072458.1429656-1-fei.w.wang@intel.com> References: <20230626072458.1429656-1-fei.w.wang@intel.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Mon, 26 Jun 2023 18:08:46 +0200 Message-ID: <168779572603.21886.11517775075604885834@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v2] fftools/ffmpeg_dec: Don't keep sending frame to filters in flushing X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Fei Wang (2023-06-26 09:24:58) > Filter may has a limited frame pool size. Do not always send frame to > filters without reaping. > > Fix the regression of commit 5fa00b38e6. > > Example cmd: > $ ffmpeg -threads 20 -init_hw_device vaapi=hw:/dev/dri/renderD128 \ > -hwaccel_output_format vaapi -hwaccel vaapi -i avc_1080P.mp4 \ > -vf 'scale_vaapi=w=720:h=480' -f null - > > Signed-off-by: Fei Wang > --- > Change: > 1. rebase to master. > > fftools/ffmpeg_dec.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/fftools/ffmpeg_dec.c b/fftools/ffmpeg_dec.c > index 85bf8dc536..a7ae51fed2 100644 > --- a/fftools/ffmpeg_dec.c > +++ b/fftools/ffmpeg_dec.c > @@ -803,6 +803,12 @@ int dec_packet(InputStream *ist, const AVPacket *pkt, int no_eof) > av_frame_unref(d->frame); > if (ret < 0) > goto finish; > + > + // During flushing, break out to reap filter once send a frame to filters to > + // avoid drain out filter's output frame pool. Especially for HW filters which > + // always have a limited frame pool size. > + if (!pkt) > + return 0; This is wrong and will leave the decoder in an inconsistent state. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".