From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [RFC] SDR
Date: Thu, 22 Jun 2023 18:09:47 +0200
Message-ID: <168745018738.21886.10926077684605560333@lain.khirnov.net> (raw)
In-Reply-To: <20230622145709.GB3250409@pb2>
Hi,
I'm sorry to say, the patch at its current state is quite far from
something I'd consider acceptable for git master.
1) Given that there are sdr and sdrfile demuxers, it seems to me that
the transport layer should be split into a protocol rather than be
inside the demuxer
2) Threading inside the demuxer, with pthread calls randomly sprinkled
throughout is particularly ugly and dangerous. Demuxers should not do
their own threading.
3) sdr_read_header() and sdr_read_packet() are giant, hideous, and
unreadable.
4) Why does there seem to be drawing code in a demuxer?
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-06-22 16:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 14:57 Michael Niedermayer
2023-06-22 15:01 ` James Almer
2023-06-22 15:09 ` Thilo Borgmann
2023-06-22 16:09 ` Anton Khirnov [this message]
2023-06-22 17:43 ` Michael Niedermayer
2023-06-22 18:52 ` Michael Niedermayer
2023-06-23 11:26 ` James Almer
2023-06-23 20:18 ` Tomas Härdin
2023-06-23 20:19 ` Tomas Härdin
2023-06-23 21:36 ` Michael Niedermayer
2023-06-24 10:12 ` Tomas Härdin
2023-06-24 21:29 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168745018738.21886.10926077684605560333@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git