From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4C0CA425A3 for ; Tue, 20 Jun 2023 19:41:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 39AD568C0C1; Tue, 20 Jun 2023 22:41:39 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5BD5A68BEFF for ; Tue, 20 Jun 2023 22:41:33 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 23D162404EC for ; Tue, 20 Jun 2023 21:41:33 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id 25irMNkTyZoU for ; Tue, 20 Jun 2023 21:41:32 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 73A512404EA for ; Tue, 20 Jun 2023 21:41:32 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 541331601B2; Tue, 20 Jun 2023 21:41:31 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <477c88ca-f9b8-aa95-a2e0-e920b1246d6f@gmail.com> References: <20230620185304.10056-1-anton@khirnov.net> <477c88ca-f9b8-aa95-a2e0-e920b1246d6f@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Tue, 20 Jun 2023 21:41:31 +0200 Message-ID: <168729009130.9711.16248011863887429642@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] tests/fate/ffmpeg: silence the audio for fate-ffmpeg-streamloop-transcode-av X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2023-06-20 21:39:22) > On 6/20/2023 3:53 PM, Anton Khirnov wrote: > > Fixed-point AAC decoder currently does not produce the same output on > > all platforms. Until that is fixed, silence the audio stream using the > > volume filter. > > > > Also, actually use the aac_fixed decoder as was the original intent. > > --- > > tests/fate/ffmpeg.mak | 7 +- > > tests/ref/fate/ffmpeg-streamloop-transcode-av | 144 +++++++++--------- > > 2 files changed, 77 insertions(+), 74 deletions(-) > > > > diff --git a/tests/fate/ffmpeg.mak b/tests/fate/ffmpeg.mak > > index 87cd0b46d0..763ed381ee 100644 > > --- a/tests/fate/ffmpeg.mak > > +++ b/tests/fate/ffmpeg.mak > > @@ -132,9 +132,12 @@ fate-ffmpeg-fix_sub_duration_heartbeat: CMD = fmtstdout srt -fix_sub_duration \ > > -c:s srt \ > > -f null - > > > > -FATE_SAMPLES_FFMPEG-$(call FRAMECRC, MATROSKA, H264 AAC_FIXED, PCM_S32LE_ENCODER) += fate-ffmpeg-streamloop-transcode-av > > +# FIXME: the integer AAC decoder does not produce the same output on all platforms > > +# so until that is fixed we use the volume filter to silence the data > > +FATE_SAMPLES_FFMPEG-$(call FRAMECRC, MATROSKA, H264 AAC_FIXED, PCM_S32LE_ENCODER VOLUME_FILTER) += fate-ffmpeg-streamloop-transcode-av > > fate-ffmpeg-streamloop-transcode-av: CMD = \ > > - framecrc -auto_conversion_filters -stream_loop 3 -i $(TARGET_SAMPLES)/mkv/1242-small.mkv -c:a pcm_s32le > > + framecrc -auto_conversion_filters -stream_loop 3 -c:a aac_fixed -i $(TARGET_SAMPLES)/mkv/1242-small.mkv \ > > + -af volume=0 -c:a pcm_s32le > > Maybe do volume=0:precision=fixed so you can remove the > -auto_conversion_filters part. It's mainly there to interleave s32p to s32 for encoding -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".