Re: [FFmpeg-devel] [PATCH] tests/fate/ffmpeg: silence the audio for fate-ffmpeg-streamloop-transcode-av

[Anton Khirnov <anton@khirnov.net>]

Quoting James Almer (2023-06-20 21:39:22)
> On 6/20/2023 3:53 PM, Anton Khirnov wrote:
> > Fixed-point AAC decoder currently does not produce the same output on
> > all platforms. Until that is fixed, silence the audio stream using the
> > volume filter.
> > 
> > Also, actually use the aac_fixed decoder as was the original intent.
> > ---
> >   tests/fate/ffmpeg.mak                         |   7 +-
> >   tests/ref/fate/ffmpeg-streamloop-transcode-av | 144 +++++++++---------
> >   2 files changed, 77 insertions(+), 74 deletions(-)
> > 
> > diff --git a/tests/fate/ffmpeg.mak b/tests/fate/ffmpeg.mak
> > index 87cd0b46d0..763ed381ee 100644
> > --- a/tests/fate/ffmpeg.mak
> > +++ b/tests/fate/ffmpeg.mak
> > @@ -132,9 +132,12 @@ fate-ffmpeg-fix_sub_duration_heartbeat: CMD = fmtstdout srt -fix_sub_duration \
> >     -c:s srt \
> >     -f null -
> >   
> > -FATE_SAMPLES_FFMPEG-$(call FRAMECRC, MATROSKA, H264 AAC_FIXED, PCM_S32LE_ENCODER) += fate-ffmpeg-streamloop-transcode-av
> > +# FIXME: the integer AAC decoder does not produce the same output on all platforms
> > +# so until that is fixed we use the volume filter to silence the data
> > +FATE_SAMPLES_FFMPEG-$(call FRAMECRC, MATROSKA, H264 AAC_FIXED, PCM_S32LE_ENCODER VOLUME_FILTER) += fate-ffmpeg-streamloop-transcode-av
> >   fate-ffmpeg-streamloop-transcode-av: CMD = \
> > -	framecrc -auto_conversion_filters -stream_loop 3 -i $(TARGET_SAMPLES)/mkv/1242-small.mkv -c:a pcm_s32le
> > +    framecrc -auto_conversion_filters -stream_loop 3 -c:a aac_fixed -i $(TARGET_SAMPLES)/mkv/1242-small.mkv \
> > +    -af volume=0 -c:a pcm_s32le
> 
> Maybe do volume=0:precision=fixed so you can remove the 
> -auto_conversion_filters part.

It's mainly there to interleave s32p to s32 for encoding

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".