From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 314944681A for ; Mon, 19 Jun 2023 16:08:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id ABEF968C061; Mon, 19 Jun 2023 19:08:51 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B30C7687FAE for ; Mon, 19 Jun 2023 19:08:45 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 7FD2A2404EC for ; Mon, 19 Jun 2023 18:08:45 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id 1rAygCDptdc8 for ; Mon, 19 Jun 2023 18:08:44 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id E8A1C2404EA for ; Mon, 19 Jun 2023 18:08:44 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id CC7E21601B2; Mon, 19 Jun 2023 18:08:44 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20230618215021.3044-1-michael@niedermayer.cc> <20230618215021.3044-6-michael@niedermayer.cc> Mail-Followup-To: FFmpeg development discussions and patches Date: Mon, 19 Jun 2023 18:08:44 +0200 Message-ID: <168719092480.21886.1747996252277018192@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 6/6] doc/developer: Require new modules to include tests X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Lynne (2023-06-18 23:55:56) > Jun 18, 2023, 23:50 by michael@niedermayer.cc: > > > Signed-off-by: Michael Niedermayer > > --- > > doc/developer.texi | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/doc/developer.texi b/doc/developer.texi > > index a7da2ce2d5..0c2f2cd7d1 100644 > > --- a/doc/developer.texi > > +++ b/doc/developer.texi > > @@ -805,7 +805,10 @@ Lines with similar content should be aligned vertically when doing so > > improves readability. > > > > @item > > -Consider adding a regression test for your code. > > +Consider adding a regression test for your code. All new modules > > +should be covered by tests. That includes demuxers, muxers, decoders, encoders > > +filters, bitstream filters, parsers. If its not possible to do that, add > > +an explanation why to your patchset, its ok to not test if theres a reason. > > > > Could you add assembly code to this as well? > checkasm is super useful, but is currently lacking quite > a few tests. The SIMD/DSP section already says new asm should have tests. I would be in favor of making that into 'must' (unless very good reason otherwise). -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".