From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/5] avcodec: Add new side data type to contain original PTS value
Date: Mon, 19 Jun 2023 16:32:31 +0200
Message-ID: <168718515193.21886.10158824507754353993@lain.khirnov.net> (raw)
In-Reply-To: <CAHGibzGhFgpvCVGH+viUoYhByHe-f3jJB8DbNgKcohrByzqutw@mail.gmail.com>
Quoting Devin Heitmueller (2023-06-19 15:14:38)
> Hi Andreas,
>
> Thanks for the feedback. I put out an RFC back in March but got no comments.
>
> On Fri, Jun 16, 2023 at 6:01 PM Andreas Rheinhardt
> <andreas.rheinhardt@outlook.com> wrote:
> > A timestamp without a timebase? Doesn't sound good to me. And it also
> > seems quite hacky.
> > Apart from that: It needs to specify that the data is a int64_t.
>
> So you're suggesting a struct that contains both the timestamp and a
> timebase? I don't have any real objection to this.
>
> I agree it seems hacky, but don't have a better solution. I welcome
> constructive suggestions. I had considered using an AVPacket metadata
> field rather than a new side data type (as that won't necessarily lock
> us into a new side data type that we would have to support),
This reasoning is backwards IMO. You'd be creating an implicit API while
pretending not to. If anyone uses it, they would expect stability,
otherwise what's the point.
> functionality is really specific to one use case. However I figured
> side data might be better since it avoids the conversion of the PTS to
> a string and back.
One one hand it does feel hacky, on the other I can see valid uses for
it. Though 'orig' is rather vague, I'd call it something like 'transport
timestamp' instead. A timebase should definitely be bundled with it.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-06-19 14:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 22:12 [FFmpeg-devel] [PATCH 0/5] Add passthrough support for SCTE-35 Devin Heitmueller
2023-06-16 22:12 ` [FFmpeg-devel] [PATCH 1/5] avcodec: Add new side data type to contain original PTS value Devin Heitmueller
2023-06-16 22:01 ` Andreas Rheinhardt
2023-06-19 13:14 ` Devin Heitmueller
2023-06-19 14:32 ` Anton Khirnov [this message]
2023-06-19 14:54 ` Devin Heitmueller
2023-06-16 22:12 ` [FFmpeg-devel] [PATCH 2/5] mpegts: Stash original PTS for SCTE-35 sections for processing later Devin Heitmueller
2023-06-16 22:12 ` [FFmpeg-devel] [PATCH 3/5] mpegtsenc: Add support for output of SCTE-35 streams over TS Devin Heitmueller
2023-06-16 22:12 ` [FFmpeg-devel] [PATCH 4/5] bsf: Add new bitstream filter to set pts_adjustment when reclocking Devin Heitmueller
2023-06-16 21:59 ` Andreas Rheinhardt
2023-06-19 13:15 ` Devin Heitmueller
2023-06-16 22:12 ` [FFmpeg-devel] [PATCH 5/5] mpegtsenc: Don't periodically announce PCR on SCTE-35 streams Devin Heitmueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168718515193.21886.10158824507754353993@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git