From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E34424675F for ; Sat, 17 Jun 2023 02:55:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DB80A68C3B3; Sat, 17 Jun 2023 05:55:11 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 011A668C390 for ; Sat, 17 Jun 2023 05:55:05 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id C03B82404EC for ; Sat, 17 Jun 2023 04:55:05 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id DjaSOPMUqT42 for ; Sat, 17 Jun 2023 04:55:05 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 3F8E82404EA for ; Sat, 17 Jun 2023 04:55:05 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 29D311601B2; Sat, 17 Jun 2023 04:55:05 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20230616205821.GL1391451@pb2> References: <20230614164908.28712-1-anton@khirnov.net> <20230614164908.28712-16-anton@khirnov.net> <20230616205821.GL1391451@pb2> Mail-Followup-To: FFmpeg development discussions and patches Date: Sat, 17 Jun 2023 04:55:05 +0200 Message-ID: <168697050513.21886.8888781283811399147@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 16/21] fftools/ffmpeg_dec: move decoding to a separate thread X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Michael Niedermayer (2023-06-16 22:58:21) > On Wed, Jun 14, 2023 at 06:49:03PM +0200, Anton Khirnov wrote: > > This is only a preparatory step to a fully threaded architecture and > > does not yet make decoding truly parallel - the main thread will > > currently submit a packet and wait until it has been fully processed by > > the decoding thread before moving on. Decoded behavior as observed by > > the rest of the program should remain unchanged. That will change in > > future commits after encoders and filters are moved to threads and a > > thread-aware scheduler is added. > > --- > > fftools/ffmpeg.c | 63 +++++--- > > fftools/ffmpeg.h | 11 ++ > > fftools/ffmpeg_dec.c | 365 ++++++++++++++++++++++++++++++++++++++----- > > fftools/ffmpeg_mux.c | 5 - > > 4 files changed, 382 insertions(+), 62 deletions(-) > > This seems to break (infinite loop) > > ffmpeg -i videos/bink/thps4/ACDC.smo -bitexact -t 1 -y ACDC.smo.avi > > file seems there: on samples server: game-formats/bink/thps4/ACDC.smo This is a bug in the binkaudio decoder, fixed by the patch I just sent. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".