From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 4C296463C3
	for <ffmpegdev@gitmailbox.com>; Thu, 15 Jun 2023 18:26:41 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8BF9F68C536;
	Thu, 15 Jun 2023 21:26:38 +0300 (EEST)
Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 43F7D68BF63
 for <ffmpeg-devel@ffmpeg.org>; Thu, 15 Jun 2023 21:26:32 +0300 (EEST)
Received: from localhost (localhost [IPv6:::1])
 by mail0.khirnov.net (Postfix) with ESMTP id C983C2404EC
 for <ffmpeg-devel@ffmpeg.org>; Thu, 15 Jun 2023 20:26:31 +0200 (CEST)
Received: from mail0.khirnov.net ([IPv6:::1])
 by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024)
 with ESMTP id N6V1c0_tFNFO for <ffmpeg-devel@ffmpeg.org>;
 Thu, 15 Jun 2023 20:26:31 +0200 (CEST)
Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256
 client-signature RSA-PSS (2048 bits) client-digest SHA256)
 (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK))
 by mail0.khirnov.net (Postfix) with ESMTPS id 016A92404EA
 for <ffmpeg-devel@ffmpeg.org>; Thu, 15 Jun 2023 20:26:30 +0200 (CEST)
Received: by lain.khirnov.net (Postfix, from userid 1000)
 id 92BB51601B2; Thu, 15 Jun 2023 20:26:29 +0200 (CEST)
From: Anton Khirnov <anton@khirnov.net>
To: Ffmpeg Devel <ffmpeg-devel@ffmpeg.org>
In-Reply-To: <NXmWSIQ--3-9@lynne.ee>
References: <NXmWSIQ--3-9@lynne.ee>
Mail-Followup-To: Ffmpeg Devel <ffmpeg-devel@ffmpeg.org>
Date: Thu, 15 Jun 2023 20:26:29 +0200
Message-ID: <168685358957.21886.17411006325784262089@lain.khirnov.net>
User-Agent: alot/0.8.1
MIME-Version: 1.0
Subject: Re: [FFmpeg-devel] [PATCH] pthread_frame: uninit the hwaccel of
 each frame thread
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/168685358957.21886.17411006325784262089@lain.khirnov.net/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

Quoting Lynne (2023-06-13 04:11:35)
> The issue is that with a threadsafe hwaccel and multiple enabled
> frame threads, hwaccel->uninit() is never called.
> Previously, the function was guaranteed to never have any threads
> with hwaccel contexts, so it never bothered to uninit it.
> 
> Patch attached.

Maybe add a note that this only does something for threadsafe hwaccels,
since otherwise hwaccel state is always cleared here.

Otherwise looks good assuming it was tested with a leak checker.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".