From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E9B11462D0 for ; Wed, 14 Jun 2023 16:53:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E18C168C4DA; Wed, 14 Jun 2023 19:51:27 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C294268C472 for ; Wed, 14 Jun 2023 19:51:21 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 8DAF62404EC for ; Wed, 14 Jun 2023 18:51:21 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id MzVbMKbVIaA5 for ; Wed, 14 Jun 2023 18:51:20 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id CD3D1240177 for ; Wed, 14 Jun 2023 18:51:20 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 405BA1601B2; Wed, 14 Jun 2023 18:51:19 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20230607191706.GE870501@pb2> References: <20230531142612.443E941082C@natalya.videolan.org> <20230607191706.GE870501@pb2> Mail-Followup-To: FFmpeg development discussions and patches Date: Wed, 14 Jun 2023 18:51:19 +0200 Message-ID: <168676147923.3843.17506690995536508697@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/ffmpeg: rework setting sub2video parameters X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Michael Niedermayer (2023-06-07 21:17:06) > On Wed, May 31, 2023 at 02:26:11PM +0000, Anton Khirnov wrote: > > ffmpeg | branch: master | Anton Khirnov | Tue May 23 22:54:23 2023 +0200| [20cacfe4936a8d5b643421b5ca93bb098f6b76dd] | committer: Anton Khirnov > > > > fftools/ffmpeg: rework setting sub2video parameters > > > > Set them in ifilter_parameters_from_dec(), similarly to audio/video > > streams. This reduces the extent to which sub2video filters need to be > > treated specially. > > > > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=20cacfe4936a8d5b643421b5ca93bb098f6b76dd > > --- > > > > fftools/ffmpeg.c | 6 ++--- > > fftools/ffmpeg_demux.c | 21 ++++++++++++++++++ > > fftools/ffmpeg_filter.c | 58 +++++++++++++++---------------------------------- > > 3 files changed, 41 insertions(+), 44 deletions(-) > > This breaks subtitle location and size > > ./ffmpeg -i ~/tickets/4752/dump_dvbsubtitles.mp4 -y -ss 5 -t 1 -filter_complex '[0:v][0:s]overlay' /tmp/file4752.ts && ffplay /tmp/file4752.ts > > https://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket4752/dump_dvbsubtitles.mp4 > > > Before this commit the subtitles are centered at the bottom of the screen > after this patch the subtitles are tiny in the left middle of the screen > > In the following case the subtitles disappear completely: > > ./ffmpeg -i ~/tickets/679/subtitles.ts -filter_complex '[0:v][0:s:0]overlay[vid]' -map '[vid]' -bitexact -t 3 file-4744-3.avi > > https://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket4744/subtitles.ts Should be fixed in the patchset I just sent. Cheers, -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".