Re: [FFmpeg-devel] [PATCH v2] avcodec/noise_bsf: Check for wrapped frames

From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/noise_bsf: Check for wrapped frames
Date: Mon, 05 Jun 2023 12:21:13 +0200
Message-ID: <168596047355.3843.6740828857692828996@lain.khirnov.net> (raw)
In-Reply-To: <20230604195322.26982-1-michael@niedermayer.cc>

Quoting Michael Niedermayer (2023-06-04 21:53:22)
> Wrapped frames contain pointers so they need specific code to
> noise them, the generic code would lead to segfaults
> 
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavcodec/noise_bsf.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/libavcodec/noise_bsf.c b/libavcodec/noise_bsf.c
> index 168f3aa373..2985a8ec4f 100644
> --- a/libavcodec/noise_bsf.c
> +++ b/libavcodec/noise_bsf.c
> @@ -86,6 +86,13 @@ static int noise_init(AVBSFContext *ctx)
>              return AVERROR(ENOMEM);
>      }
>  
> +    if (ctx->par_in->codec_id == AV_CODEC_ID_WRAPPED_AVFRAME &&
> +        strcmp(s->amount_str, "0")
> +    ) {

Why is this on a separate line?

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".