From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E07E745D20 for ; Mon, 5 Jun 2023 10:09:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2992368C3E6; Mon, 5 Jun 2023 13:09:26 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 08CB468C2DC for ; Mon, 5 Jun 2023 13:09:20 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id C5F97240177 for ; Mon, 5 Jun 2023 12:09:19 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id 2mGgkgjyqdax for ; Mon, 5 Jun 2023 12:09:19 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 479302404EC for ; Mon, 5 Jun 2023 12:09:19 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 368381601B2; Mon, 5 Jun 2023 12:09:19 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20230501114456.13898-1-epirat07@gmail.com> <20230521235235.GC14958@mariano> <8CA999C7-1502-4FAB-ACD9-9BC02ED68058@gmail.com> <20230526060544.GB3241@mariano> <20230604142540.GA4274@mariano> <47F94F3B-C372-4150-85C3-044082905B27@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Mon, 05 Jun 2023 12:09:19 +0200 Message-ID: <168595975919.3843.2883163357995988410@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 1/3] avutil/dict: add av_dict_pop X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Stefano Sabatini (2023-06-05 10:08:07) > Il dom 4 giu 2023, 16:34 Marvin Scholz ha scritto: > > > On 4 Jun 2023, at 16:25, Stefano Sabatini wrote: > > [...] > > > About your patch, please mention that the pop operation is > > > destructive. We probably want to make that behavior configurable > > > through flags, but I'm fine to keep the current behavior for > > > consistency with the set(NULL) operation. > > > > What do you mean by "destructive"? > > > > I mean that the dictionary structure will be freed when the last element > is popped. It is explicitly mentioned in the documentation that NULL is a valid representation of an empty dictionary, so I don't think there's anything destructive here. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".