From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/3] avutil/dict: add av_dict_pop
Date: Mon, 05 Jun 2023 12:09:19 +0200
Message-ID: <168595975919.3843.2883163357995988410@lain.khirnov.net> (raw)
In-Reply-To: <CAMcAR4r2N7To=zCzbByF6twFPoqgM4kMcGo1LRTHUyAGQii-ew@mail.gmail.com>
Quoting Stefano Sabatini (2023-06-05 10:08:07)
> Il dom 4 giu 2023, 16:34 Marvin Scholz <epirat07@gmail.com> ha scritto:
>
> > On 4 Jun 2023, at 16:25, Stefano Sabatini wrote:
> > [...]
> > > About your patch, please mention that the pop operation is
> > > destructive. We probably want to make that behavior configurable
> > > through flags, but I'm fine to keep the current behavior for
> > > consistency with the set(NULL) operation.
> >
> > What do you mean by "destructive"?
> >
>
> I mean that the dictionary structure will be freed when the last element
> is popped.
It is explicitly mentioned in the documentation that NULL is a valid
representation of an empty dictionary, so I don't think there's anything
destructive here.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-06-05 10:09 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-01 11:44 Marvin Scholz
2023-05-01 11:44 ` [FFmpeg-devel] [PATCH 2/3] avformat/tee: use av_dict_pop Marvin Scholz
2023-06-25 12:07 ` "zhilizhao(赵志立)"
2023-05-01 11:44 ` [FFmpeg-devel] [PATCH 3/3] avutil/dict: constify av_dict_get return Marvin Scholz
2023-06-05 10:05 ` Anton Khirnov
2023-05-21 23:52 ` [FFmpeg-devel] [PATCH 1/3] avutil/dict: add av_dict_pop Stefano Sabatini
2023-05-22 9:23 ` Marvin Scholz
2023-05-26 6:05 ` Stefano Sabatini
2023-05-26 9:11 ` Marvin Scholz
2023-05-26 20:02 ` Michael Niedermayer
2023-05-26 20:51 ` Marvin Scholz
2023-05-26 20:06 ` James Almer
2023-06-04 14:25 ` Stefano Sabatini
2023-06-04 14:34 ` Marvin Scholz
2023-06-05 8:08 ` Stefano Sabatini
2023-06-05 10:09 ` Anton Khirnov [this message]
2023-06-05 10:04 ` Anton Khirnov
2023-06-25 10:49 ` [FFmpeg-devel] [PATCH v2 " Marvin Scholz
2023-06-25 10:49 ` [FFmpeg-devel] [PATCH v2 2/3] avformat/tee: use av_dict_pop Marvin Scholz
2023-07-02 8:47 ` Stefano Sabatini
2023-06-25 10:49 ` [FFmpeg-devel] [PATCH v2 3/3] avutil/dict: constify av_dict_get return Marvin Scholz
2023-07-02 9:06 ` Stefano Sabatini
2023-07-02 8:43 ` [FFmpeg-devel] [PATCH v2 1/3] avutil/dict: add av_dict_pop Stefano Sabatini
2023-07-02 11:49 ` Marvin Scholz
2023-07-03 0:18 ` Andreas Rheinhardt
2023-07-03 9:11 ` Marvin Scholz
2023-07-03 18:02 ` Andreas Rheinhardt
2023-07-03 22:41 ` Marvin Scholz
2023-10-20 8:18 ` Anton Khirnov
2023-10-20 14:00 ` Andreas Rheinhardt
2023-10-20 14:33 ` Anton Khirnov
2023-10-20 15:42 ` Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168595975919.3843.2883163357995988410@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git