From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9C6154608D for ; Sat, 3 Jun 2023 10:02:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 629AD68C2E9; Sat, 3 Jun 2023 13:02:24 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3485F68C0A6 for ; Sat, 3 Jun 2023 13:02:18 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id EF6592404EC for ; Sat, 3 Jun 2023 12:02:17 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id WZ46ZezbBiDc for ; Sat, 3 Jun 2023 12:02:17 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 6B511240177 for ; Sat, 3 Jun 2023 12:02:17 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 4F3CE1601B2; Sat, 3 Jun 2023 12:02:15 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20230120193132.21597-1-anton@khirnov.net> <20230120193132.21597-4-anton@khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Sat, 03 Jun 2023 12:02:15 +0200 Message-ID: <168578653529.3843.11543958671793214785@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 4/5] lavfi/graphparser: reimplement avfilter_graph_parse* using new API X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Marton Balint (2023-05-30 23:09:50) > > > On Fri, 20 Jan 2023, Anton Khirnov wrote: > > > --- > > libavfilter/graphparser.c | 537 +++++++++----------------------------- > > 1 file changed, 126 insertions(+), 411 deletions(-) > > This change makes error messages for parse failures less useful or > completely missing. E.g.: > > ffmpeg -f lavfi -i testsrc -vf yadif,scale=dummy=boo -f null none > > Before: > > [Parsed_scale_0 @ 0x555c19335b00] Option 'dummy' not found > [AVFilterGraph @ 0x555c19333e00] Error initializing filter 'scale' with args 'dummy=boo:flags=bicubic' > Error reinitializing filters! > > After: > > [AVFilterGraph @ 0x3c5a100] Error applying filter options > Error reinitializing filters! Cannot reproduce, for me current git master says: Input #0, lavfi, from 'testsrc': Duration: N/A, start: 0.000000, bitrate: N/A Stream #0:0: Video: wrapped_avframe, rgb24, 320x240 [SAR 1:1 DAR 4:3], 25 fps, 25 tbr, 25 tbn Error applying option 'dummy' to filter 'scale': Option not found Option not found Which could be improved, but it does mention the unknown option name. > ffplay -f lavfi -i testsrc -vf yadif,scale=dummy=boo > > Before: > > [Parsed_scale_1 @ 0x55fa2b935080] Option 'dummy' not found > Error initializing filter 'scale' with args 'dummy=boo:flags=bicubic' > > After: > > (no error message) Should be addressed by the patch I just sent. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".